Conversation
lprnmns
marked this pull request as ready for review
August 31, 2026 14:07
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When an ESM-syntax JavaScript or TypeScript module is transformed to CommonJS by tsx, its synthesized import.meta object has no resolve function. A CJS entry that requires such a module therefore gets TypeError: define_import_meta_default.resolve is not a function. This reproduces the remaining gap described in #744.
Fix
Keep the existing synthesized metadata values and add a synchronous import.meta.resolve-compatible shim for CJS-transformed modules. Relative, absolute, URL, builtin, package-import, query, and conditional-export cases are covered by the URL path and Node resolver branches. A per-file collision-safe helper keeps user
modulebindings from shadowing the synthesized object. Native ESM transforms are unchanged.Tests
Compatibility
The change is limited to CJS transforms that contain import.meta. It does not add dependencies or change the lockfile. Bare package resolution uses Node's existing resolver with node/import conditions; the broader test suite passed on Node 24.15.0.
Related issue
Fixes #744