embedding cache steps by using @actions/cache#31
Merged
asottile merged 2 commits intopre-commit:masterfrom Jun 13, 2020
trim21:master
Merged
embedding cache steps by using @actions/cache#31asottile merged 2 commits intopre-commit:masterfrom trim21:master
asottile merged 2 commits intopre-commit:masterfrom
trim21:master
Conversation
asottile
reviewed
Jun 8, 2020
Member
asottile
left a comment
asottile
left a comment
There was a problem hiding this comment.
seems good, this wasn't an option when it was originally written
please revert style changes and structure changes and run the pre-commit hooks (lol)
asottile
reviewed
Jun 11, 2020
asottile
reviewed
Jun 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a proposal, feel free to close it.
There is no need to add cache steps as
@actions/cacheis released and github actions can use it to cache files instead of adding a extra step.