Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

Promises on .request and node-style callbacks on .reply is unbalanced #6

Description

@dantman

The API is confusing.

Using promises is lovely, but envelope.reply appears to be a node-style callback.

I was actually bitten by this, I expected .reply to simply accept my data and ended up having to dig up where an error Firefox couldn't print was coming from.

I would recommend an alternative to .reply that simply accepts a value, paired with another that accepts an error.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions