Client side tests for analysis-runner - #758
Conversation
Planning PR for the analysis-runner tw mode. No implementation yet — this commit only anchors the branch so reviewers can engage with the design described in the PR body before any code lands. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
MattWellie
left a comment
There was a problem hiding this comment.
Good start. You can push the pre-commit versions even higher - pre-commit in general is at 6.0.0+, mypy has a version v2.1.0.
The get_repository_specific_information method is probably running as part of this call, and will pass if this testing branch is currently pushed to github which is a bit meta. Probably worth adding those checks in, as it's something we'll be re-using in TW... unless we exclusively stick with named workflows, I can't remember if we came to a decision on this.
|
Confirming a few things from playing locally -
in the tests:
-- Feels bad raising these as issues and just... passing them over, lmk if you want to combine on this |
MattWellie
left a comment
There was a problem hiding this comment.
LGTMatt - doesn't touch functional code, adds tests, updates/modernises requirements and packaging. What's not to love? Maybe a version bump and a second approval from software 👀
violetbrina
left a comment
There was a problem hiding this comment.
Thanks so much for your work adding tests to the analysis-runner, a much overdue addition for sure. I have some very minor comments, and I'm not sure if @dancoates or anyone else from @populationgenomics/software-team wants eyes on this as well.
But looking good.
|
@violetbrina , I believe I've addressed everything, thanks for the feedback. |
| # via hail | ||
| aiosignal==1.4.0 | ||
| # via aiohttp | ||
| analysis-runner[test] @ file:///opt/deps |
There was a problem hiding this comment.
| analysis-runner[test] @ file:///opt/deps | |
| analysis-runner[test] |
This is breaking CI
There was a problem hiding this comment.
I've made a side PR stacked on this branch - it un-nests the analysis-runner [dev] and [test] optional dependencies, and changes how the package is installed in CI.
It also rebuilds the requirements-dev file with uv instead of pip - it should be equivalent, but the file header is explicit about being created with UV Which we may not want
|
@nevoodoo This is a package of tests that I wrote for the client side of analysis-runner. I had some packaging changes here as well, but in light of the work you are doing, have taken them out. |
Adding some client side tests for analysis-runner, before I make any changes to include Nextflow tower as a supported dispatch mode.
ALSO centralise dependency management into
pyproject.tomlcli.pyandcli_analysisrunner.py.mypyandruff, as they were quite outdated.pyproject.toml, deletesetup.pyetc, update build references.