feat: Add SQL support for INTERSECT and EXCEPT ops#16960
Merged
ritchie46 merged 1 commit intopola-rs:mainfrom Jun 15, 2024
Merged
feat: Add SQL support for INTERSECT and EXCEPT ops#16960ritchie46 merged 1 commit intopola-rs:mainfrom
INTERSECT and EXCEPT ops#16960ritchie46 merged 1 commit intopola-rs:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16960 +/- ##
==========================================
+ Coverage 80.95% 81.03% +0.07%
==========================================
Files 1445 1445
Lines 189822 190276 +454
Branches 2712 2712
==========================================
+ Hits 153675 154191 +516
+ Misses 35647 35586 -61
+ Partials 500 499 -1 ☔ View full report in Codecov by Sentry. |
ritchie46
approved these changes
Jun 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features
EXCEPT1 andINTERSECT2 ops.ARRAY_TO_STRINGso that it works with non-string arrays (casts inner type).TABLE xyz3 PostgreSQL shortcut syntax.SQLSyntaxErrormessage tidy-ups.Also
sqlparser-rsto the latest released version (0.47.0); this actually turned into majority of the PR, as various aspects ofFunctionrepresentation were consolidated4, requiring non-trivial changes on our side. However, it does leave things in a better place, and allows for additional centralisation/validation of function properties & syntax 👌Follow-up
[EXCEPT | INTERSECT] BY NAME, but it won't get parsed until we pick up a newsqlparser-rswith this PR merged: Support use ofBY NAMEquantifier across all set ops apache/datafusion-sqlparser-rs#1309 (no rush).Examples
EXCEPT:INTERSECT:Footnotes
https://www.postgresql.org/docs/current/sql-select.html#SQL-EXCEPT ↩
https://www.postgresql.org/docs/current/sql-select.html#SQL-INTERSECT ↩
https://www.postgresql.org/docs/current/sql-select.html#SQL-TABLE ↩
https://github.com/sqlparser-rs/sqlparser-rs/pull/1247 ↩