Adds support for SPFx v1.23.0#7258
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the SPFx tooling in CLI for Microsoft 365 to recognize and work with SharePoint Framework v1.23.0 (stable), updating the compatibility matrix, project upgrade/doctor logic, and adding an SPFx 1.23.0 test project used by the e2e validation suites.
Changes:
- Updated SPFx compatibility/version support from
1.23.0-rc.0to1.23.0across the compatibility matrix, project upgrade, project doctor, and docs. - Extended the 1.23.0 upgrade rules (new deps, overrides handling, SCSS import change) and updated upgrade/doctor e2e fixtures & expectations.
- Added a new SPFx 1.23.0 React web part test project fixture (
spfx-1230-webpart-react) for validations.
Reviewed changes
Copilot reviewed 18 out of 41 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils/packageManager.ts | Changes ordering of override/removeOverride commands in the reduced package-manager command list. |
| src/m365/spfx/commands/SpfxCompatibilityMatrix.ts | Switches compatibility matrix entry from 1.23.0-rc.0 to 1.23.0. |
| src/m365/spfx/commands/project/test-projects/spfx-1230-webpart-react/tsconfig.json | Adds SPFx 1.23.0 test project tsconfig extending build rig defaults. |
| src/m365/spfx/commands/project/test-projects/spfx-1230-webpart-react/teams/2d903eb4-9a56-4eab-99b4-c48abb19e267_outline.png | Adds Teams asset for the new test project fixture. |
| src/m365/spfx/commands/project/test-projects/spfx-1230-webpart-react/teams/2d903eb4-9a56-4eab-99b4-c48abb19e267_color.png | Adds Teams asset for the new test project fixture. |
| src/m365/spfx/commands/project/test-projects/spfx-1230-webpart-react/src/webparts/helloWorld/loc/mystrings.d.ts | Adds localization typings for the new test project web part. |
| src/m365/spfx/commands/project/test-projects/spfx-1230-webpart-react/src/webparts/helloWorld/loc/en-us.js | Adds en-us string resources for the new test project web part. |
| src/m365/spfx/commands/project/test-projects/spfx-1230-webpart-react/src/webparts/helloWorld/HelloWorldWebPart.ts | Adds SPFx 1.23.0 web part implementation used as doctor/upgrade fixture. |
| src/m365/spfx/commands/project/test-projects/spfx-1230-webpart-react/src/webparts/helloWorld/HelloWorldWebPart.manifest.json | Updates the web part manifest id for the new fixture. |
| src/m365/spfx/commands/project/test-projects/spfx-1230-webpart-react/src/webparts/helloWorld/components/IHelloWorldProps.ts | Adds props interface for the fixture React component. |
| src/m365/spfx/commands/project/test-projects/spfx-1230-webpart-react/src/webparts/helloWorld/components/HelloWorld.tsx | Adds fixture React component. |
| src/m365/spfx/commands/project/test-projects/spfx-1230-webpart-react/src/webparts/helloWorld/components/HelloWorld.module.scss | Updates SCSS import style for Fluent UI references (SPFx 1.23 pattern). |
| src/m365/spfx/commands/project/test-projects/spfx-1230-webpart-react/src/webparts/helloWorld/assets/welcome-light.png | Adds fixture asset. |
| src/m365/spfx/commands/project/test-projects/spfx-1230-webpart-react/src/webparts/helloWorld/assets/welcome-dark.png | Adds fixture asset. |
| src/m365/spfx/commands/project/test-projects/spfx-1230-webpart-react/README.md | Updates fixture README badge to v1.23.0 stable. |
| src/m365/spfx/commands/project/test-projects/spfx-1230-webpart-react/package.json | Updates fixture deps from 1.23.0-rc.0 to 1.23.0 and adjusts related tooling deps. |
| src/m365/spfx/commands/project/test-projects/spfx-1230-webpart-react/eslint.config.js | Adds flat ESLint config for the fixture project. |
| src/m365/spfx/commands/project/test-projects/spfx-1230-webpart-react/config/write-manifests.json | Adds fixture build config. |
| src/m365/spfx/commands/project/test-projects/spfx-1230-webpart-react/config/typescript.json | Adds fixture build config for TypeScript/static asset copying. |
| src/m365/spfx/commands/project/test-projects/spfx-1230-webpart-react/config/serve.json | Adds fixture serve configuration. |
| src/m365/spfx/commands/project/test-projects/spfx-1230-webpart-react/config/sass.json | Adds fixture sass config (heft sass plugin). |
| src/m365/spfx/commands/project/test-projects/spfx-1230-webpart-react/config/rig.json | Adds fixture rig configuration pointing at spfx-web-build-rig. |
| src/m365/spfx/commands/project/test-projects/spfx-1230-webpart-react/config/package-solution.json | Adds/updates fixture solution packaging metadata for v1.23.0. |
| src/m365/spfx/commands/project/test-projects/spfx-1230-webpart-react/config/deploy-azure-storage.json | Adds fixture deploy-azure-storage config. |
| src/m365/spfx/commands/project/test-projects/spfx-1230-webpart-react/config/config.json | Adds fixture bundle/resource config. |
| src/m365/spfx/commands/project/test-projects/spfx-1230-webpart-react/.yo-rc.json | Updates fixture generator metadata to v1.23.0 stable and new ids. |
| src/m365/spfx/commands/project/test-projects/spfx-1230-webpart-react/.vscode/settings.json | Adds fixture VS Code settings. |
| src/m365/spfx/commands/project/test-projects/spfx-1230-webpart-react/.vscode/launch.json | Adds fixture VS Code launch configuration. |
| src/m365/spfx/commands/project/test-projects/spfx-1230-webpart-react/.npmignore | Adds fixture npmignore. |
| src/m365/spfx/commands/project/test-projects/spfx-1230-webpart-react/.gitignore | Adds fixture gitignore. |
| src/m365/spfx/commands/project/project-upgrade/upgrade-1.23.0.ts | Updates upgrade rules to target SPFx 1.23.0 stable and adds new rule entries. |
| src/m365/spfx/commands/project/project-upgrade/rules/FN027001_OVERRIDES_rushstack_heft.ts | Modifies override rule to emit an extra “remove override first” finding. |
| src/m365/spfx/commands/project/project-upgrade/rules/FN027001_OVERRIDES_rushstack_heft.spec.ts | Updates/adds unit tests for the override rule’s new behavior. |
| src/m365/spfx/commands/project/project-upgrade/rules/FN002036_DEVDEP_types_jest.ts | Adds a new upgrade rule for @types/jest. |
| src/m365/spfx/commands/project/project-upgrade/rules/FN002035_DEVDEP_types_heft_jest.ts | Extends rule to support removal via an add flag. |
| src/m365/spfx/commands/project/project-upgrade.ts | Updates supported upgrade target list to include 1.23.0 (stable) and comments out prerelease support code. |
| src/m365/spfx/commands/project/project-upgrade.spec.ts | Updates tests for new command ordering and updated 1.23.0 findings counts. |
| src/m365/spfx/commands/project/project-doctor/doctor-1.23.0.ts | Adds SPFx 1.23.0 doctor ruleset. |
| src/m365/spfx/commands/project/project-doctor.ts | Updates supported doctor versions to include 1.23.0 (stable). |
| src/m365/spfx/commands/project/project-doctor.spec.ts | Points 1.23.0 e2e test at the new stable test project fixture. |
| docs/docs/cmd/spfx/project/project-upgrade.mdx | Updates docs remark to reference v1.23.0 stable as latest supported. |
milanholemans
force-pushed
the
spfx-123
branch
2 times, most recently
from
d1d81c7 to
2b55f07
Compare
Member
|
hi, due to a patch release, we needed to perform we had to rebase the main branch, which now makes this PR out of sync with the latest state of main. |
Adam-it
approved these changes
May 19, 2026
Member
Adam-it
left a comment
Adam-it
left a comment
There was a problem hiding this comment.
Checked:
- doctor
- project doctor
- project upgrade on 1.22.2
- project upgrade on 1.18.2
- project upgrade on 1.23.0
LGMT 🔥
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7257