Skip to content

Extends 'spe container get' command. Closes #6719#7052

Draft
Adam-it wants to merge 1 commit into
pnp:mainfrom
Adam-it:extends-containet-get-command
Draft

Extends 'spe container get' command. Closes #6719#7052
Adam-it wants to merge 1 commit into
pnp:mainfrom
Adam-it:extends-containet-get-command

Conversation

@Adam-it
Copy link
Copy Markdown
Member

@Adam-it Adam-it commented Nov 29, 2025

Closes #6719

@Adam-it Adam-it changed the title Extends 'spo container get' command. Closes #6719 Extends 'spe container get' command. Closes #6719 Nov 29, 2025
Copy link
Copy Markdown
Contributor

@MartinM85 MartinM85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @Adam-it 🚀

I have a few notes regarding the API calls optimization.

Comment thread src/m365/spe/commands/container/container-get.ts Outdated
Comment thread src/m365/spe/commands/container/container-get.spec.ts Outdated
@MartinM85 MartinM85 self-assigned this Dec 15, 2025
@MartinM85 MartinM85 marked this pull request as draft January 1, 2026 13:50
@Adam-it Adam-it force-pushed the extends-containet-get-command branch from 08fabbf to 7223c47 Compare May 18, 2026 22:19
@Adam-it Adam-it force-pushed the extends-containet-get-command branch from 7223c47 to 25099ab Compare May 19, 2026 21:36
@Adam-it Adam-it marked this pull request as ready for review May 19, 2026 21:37
@Adam-it
Copy link
Copy Markdown
Member Author

Adam-it commented May 19, 2026

@MartinM85 sorry for the huge hold up from my side. The PR should be ready

Copy link
Copy Markdown
Contributor

@MartinM85 MartinM85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Adam-it, I've one note how to reuse the existing util method to get a container id by name.


const containerTypeId = await this.getContainerTypeId(options, logger);

const containers = await odata.getAllItems<SpeContainer>(`${this.resource}/v1.0/storage/fileStorage/deletedContainers?$filter=containerTypeId eq ${containerTypeId}&$select=id,displayName`);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you try to get a container id from deleted ones?
I see that the spe util has the getContainerIdByName method, so you can use it.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aaaaj. A copy paste error.
Sorry for that, will reuse the util

@MartinM85 MartinM85 marked this pull request as draft May 22, 2026 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a name option to spe container get command

2 participants