fix(ts-sdk): validate hosted limit order price#1291
Open
realfishsam wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
CI note: the scoped TypeScript hosted price-validation change is covered by the targeted regression test, but generated-sync checks are currently red from unrelated repo-wide drift on Local checks run:
Blocked checks observed on GitHub:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildOrdervalidation for limit-orderpricepresence and positivity.Fixes #1287
Test Plan
npm test -- --runTestsByPath tests/hosted-dispatch.test.ts -t "positive price" --runInBand(pass; used local untrackedgenerated/srcstubs because this checkout cannot regenerate TypeScript OpenAPI output:javais unavailable)npm test -- --runTestsByPath tests/hosted-dispatch.test.ts --runInBand(blocked by pre-existing/local generated-stub limitations outside this change:fetchBalanceempty stub response andNotSupportedinstanceof mismatch)npm run generate:sdk:typescript --workspace=pmxt-core(blocked locally:java: not found)git diff --check