fix(core): type live numeric response fields#1217
Conversation
|
Validation update:
|
PR Review: PASS (NOT VERIFIED)What This DoesUpdates the core raw venue TypeScript models so live numeric fields that arrive as strings from Limitless and Probable are typed as Blast RadiusCore exchange raw types for Limitless and Probable plus normalizer regression tests. No OpenAPI schema, SDK shim, auth, router, or generated SDK files are changed. Consumer VerificationBefore (base branch): After (PR branch): // core/src/exchanges/limitless/fetcher.ts
volumeFormatted?: number | string;
volume?: number | string;
// core/src/exchanges/probable/fetcher.ts
volume24hr?: number | string;
volume?: number | string;
liquidity?: number | string;Focused normalizer tests confirm string numeric fixtures still normalize to number-valued unified fields. Test Results
FindingsNo blocking findings. PMXT Pipeline Check
Semver Impactpatch -- type accuracy/regression coverage for existing normalized fields, with no public response-shape change. RiskLive venue verification was not performed, so this review verifies the static type contract and normalizer behavior rather than a live Limitless/Probable sidecar response. |
Summary
volume/volumeFormattedpayload fields asnumber | stringvolume24hr/volume/liquiditypayload fields asnumber | stringFixes #1211
Fixes #1212
Fixes #1213
Test Plan
npm test --workspace=pmxt-core -- --runTestsByPath test/normalizers/exchange-normalizers.test.ts test/normalizers/exchange-normalizers-2.test.ts(300 passed)npm run build --workspace=pmxt-core