Repository navigation
fix(rafz): stop springs ticking twice per frame after the loop goes idle - #2598
Merged
Merged
Conversation
…rame The loop books its next frame before checking for work, so a loop that has just gone idle still has a frame booked. Starting an animation before that frame booked a second one, and both loops then ticked every job each frame until everything came to rest. A restart now reuses the booked frame.
🦋 Changeset detectedLatest commit: 0b8dd3b The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
An animation that starts just after the previous one came to rest now ticks once per frame. Before, it ticked twice until everything settled, so physics springs ran fast and duration springs could report a
NaNvelocity.The frame loop books its next frame before it checks for work, so a loop that has just gone idle still has a frame booked. Starting an animation before that frame booked a second one, and both loops kept running.