Embedded image question description#2901
Merged
btry merged 3 commits intopluginsGLPI:support/2.13.0from Jul 28, 2022
Merged
Conversation
btry
force-pushed
the
bugfix/embedded_image_question_description
branch
from
35d2db1 to
8abeafd
Compare
btry
force-pushed
the
bugfix/embedded_image_question_description
branch
from
8abeafd to
8bb34b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Management of embedded images was hacky and broke under GLPI 10
All recent improvements in the core helps to go into a more standard implemetnastin with CommonDBTM::addFiles().
Still hacky to handle textareafields, but better impleemtnation is expected in next bugfix or minor version.