fix: Handle arrays in BooleanValidator#5464
Merged
camdecoster merged 2 commits intomainfrom Jan 13, 2026
Merged
Conversation
emilykl
reviewed
Jan 13, 2026
| if isinstance(val, list): | ||
| assert val == v | ||
| else: | ||
| assert val == tuple(v) |
Contributor
There was a problem hiding this comment.
Suggested change
| assert val == tuple(v) | |
| assert list(val) == v |
clearer IMO
Contributor
Author
There was a problem hiding this comment.
With your change, I removed the if/else block. Clearer indeed.
emilykl
reviewed
Jan 13, 2026
| invalid_els = [e for e in v if not isinstance(e, bool)] | ||
| if invalid_els: | ||
| self.raise_invalid_elements(invalid_els[:10]) | ||
| v = to_scalar_or_list(v) |
Contributor
There was a problem hiding this comment.
Not 100% sure whether this call to to_scalar_or_list() is necessary, but I don't think it will hurt.
This was referenced Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update
BooleanValidatorto handle arrays of values.Addresses half of #5463. The other half is addressed by #5465.
Changes
BooleanValidatorTesting
ValueErroris raised