Fix KeyError when using column of pd.Categorical dtype with unobserved categories - #4437
Merged
alexcjohnson merged 4 commits intoNov 23, 2023
Merged
Conversation
alexcjohnson
approved these changes
Nov 22, 2023
alexcjohnson
left a comment
Collaborator
There was a problem hiding this comment.
💃 Thanks @arcanaxion, your fix looks great, and thanks so much for the clean & clear test.
CI failure looks flaky, I've rerun it. Would you add a changelog entry, then we can merge?
Contributor
Author
|
Thanks @alexcjohnson! Just added a changelog entry. Will this do? |
Contributor
|
Thank you for this PR @arcanaxion |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR passes
observed=Trueto omit categorical values with no observations in the dataset. Fixes #4274 and #4433.Also silences the FutureWarning from pandas-dev/pandas#43999 since pandas 2.1 that the default of
observed=Falsewill be changed toTruein a future version.Following code raises
KeyError: 'Fri'before this fix: