Skip to content

Drop support for deprecated annotation.ref attribute (use annotation.xref and annotation.yref instead) - #7215

Merged
emilykl merged 5 commits into
masterfrom
drop-annotations-ref
Oct 8, 2024
Merged

Drop support for deprecated annotation.ref attribute (use annotation.xref and annotation.yref instead)#7215
emilykl merged 5 commits into
masterfrom
drop-annotations-ref

Conversation

@emilykl

@emilykl emilykl commented Oct 7, 2024

Copy link
Copy Markdown
Contributor

Closes #7191

  • Drop support for deprecated annotation.ref attribute (use annotation.xref and annotation.yref instead)

@emilykl
emilykl requested review from archmoj and gvwilson October 7, 2024 23:16
Comment thread test/image/mocks/11.json
"tag": "",
"ref": "paper"
"xref": "paper",
"yref": "paper"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just for my own learning, why has the "ref" property become "xref" and "yref"?

@alexcjohnson alexcjohnson Oct 8, 2024

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So that you can place an annotation at a fixed horizontal position (xref=“paper”) and data-referenced vertical position (yref=“y”) for example. With a single ref things like that are not possible.

@gvwilson gvwilson added feature something new P1 needed for current cycle labels Oct 8, 2024

@archmoj archmoj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@emilykl
emilykl merged commit 7194259 into master Oct 8, 2024
@emilykl
emilykl deleted the drop-annotations-ref branch October 8, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature something new P1 needed for current cycle

Projects

None yet

Development

Successfully merging this pull request may close these issues.

drop deprecated annotations ref in v3

4 participants