Conversation
archmoj
reviewed
Mar 19, 2020
|
|
||
| // If in compare mode, select every point at position | ||
| if(hoverData[0].length !== 0 && | ||
| ['x', 'y'].indexOf(mode) !== -1 && |
Contributor
There was a problem hiding this comment.
concerning
['x', 'y'].indexOf(mode) !== -1 creating a dynamic array of strings just for index checking might be slow.
Could we create a constant e.g.
var XY = ['x', 'y'];at the upper scope and reuse that here?
Collaborator
There was a problem hiding this comment.
or even var XY = {x: 1, y: 1} -> if(XY[mode]) 😅
archmoj
reviewed
Mar 19, 2020
archmoj
reviewed
Mar 19, 2020
|
|
||
| // Remove duplicated hoverData points | ||
| // note that d3 also filters identical points in the rendering steps | ||
| // TODO: use ES6 map |
Collaborator
There was a problem hiding this comment.
I don't think we can make that a TODO just yet - perhaps if & when we convert the whole syntax to ES6 we can make sure we include polyfills for this and other feature, THEN we can use it whenever we wish...
alexcjohnson
approved these changes
Mar 19, 2020
alexcjohnson
left a comment
alexcjohnson
left a comment
Collaborator
There was a problem hiding this comment.
This looks great. Just a few nonblocking comments. 💃
Contributor
Author
Great! I'll merge as soon as the tests pass |
Contributor
|
Nicely done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4656
Codepen: https://codepen.io/antoinerg/pen/gOpKwPg
First commit simply wrap existing logic into a function. Second commit changes the existing behavior.