Update ja.js - #2558
Merged
Merged
Update ja.js#2558
Conversation
| 'lat:': '緯度:', // traces/scattergeo/calc.js:48 | ||
| 'lon:': '経度:', // traces/scattergeo/calc.js:49 | ||
| 'q1:': 'q1:', // traces/box/calc.js:130 | ||
| 'q3:': 'q3:', // traces/box/calc.js:131 |
Collaborator
There was a problem hiding this comment.
Are q1 and q3 OK left in English? These are the first and third quartiles, in a box plot.
Collaborator
|
Thanks @jins-tkomoda - can you recommend another Japanese speaker to review? |
Collaborator
|
The two newest keys (which some of our first translations haven't updated to add) didn't make it into your list, could you add them? These are: |
tkomde
commented
Apr 17, 2018
tkomde
left a comment
tkomde
left a comment
Author
There was a problem hiding this comment.
- added q1/q3 translations
- added missing 2 other translations
Author
|
@yuji-uema @mbfts-ts could you check the translations? |
|
@jins-tkomoda |
Collaborator
|
Thanks @mbfts-ts for reviewing. And thanks @jins-tkomoda for the translations and edits! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Japanese dictionary translations. (sorry, i couldn't update label to "type: translation",,, )