support named callback args not wrapped in a list#1375
Merged
alexcjohnson merged 2 commits intodevfrom Aug 20, 2020
Merged
Conversation
|
|
||
| args, kwargs = make_args( | ||
| Output("out1", "children"), Input("in", "children"), State("state", "children") | ||
| ) |
Marc-Andre-Rivet
approved these changes
Aug 20, 2020
Contributor
Marc-Andre-Rivet
left a comment
Marc-Andre-Rivet
left a comment
There was a problem hiding this comment.
💃 What's not to like? This fix is 99% comments and tests! 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1366
I opted to allow any of the callback args to be provided as a list or not, rather than a narrower fix of just the
output=Output(...)regression. My rationale is it's unambiguous what the user means, so there's no harm accepting it.CHANGELOG.md