Merged
Conversation
Add short explanation of reorg in README
|
Oh wait actually - why is this not running in the CI? |
Clarify that this repository does not contain code for the Chart Studio web service
Collaborator
Author
@marthacryan I didn't want to enable the CI because it doesn't currently pass. (It wasn't being run at all in the Plotly.py repo.) I agree it's not great to have a CI workflow just hanging around that we're not using though. I'll take a bit more time today to see if I can get it to pass... if not, plausibly we should just delete it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current state of the
mainbranch is an exact copy of thepackages/python/chart-studiodirectory as of Jan 2024.This PR adds a few minor changes to account for this package being moved to its own repository:
chart-studiotests (which was previously part of.circleci/config.ymlin the Plotly.py repo) to a Github Action, and updates the job so that the tests run successfullyrelease.mdcontaining the section of the Plotly.pyrelease.mddoc which are relevant to Chart Studiosetup.py