Handle mathjax arg when passed to Kaleido constructor - #320
Merged
Conversation
ayjayt
approved these changes
Apr 28, 2025
ayjayt
left a comment
ayjayt
left a comment
Collaborator
There was a problem hiding this comment.
huh interesting illl have to look more closely to see what i did
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle
mathjaxarg when passed to Kaleido constructor via**kwargs.mathjaxneed to be popped fromkwargsbeforekwargsis passed tochoreo.Browser(); and thenmathjaxneeds to be passed as an argument toPageGenerator().Without this change, calling
kaleido.calc_fig_sync(..., kopts=dict(mathjax="<mathjax-url>"))fails with the following error raised bychoreographer:RuntimeError: Chromium.get_cli() received invalid args: dict_keys(['mathjax'])This PR also updates the test in
test_calc_fig.pyto test passing a Mathjax url.