feat(web): add URL parameter support for auto-opening plugin install modal - #8
Merged
Merged
Conversation
…modal Enable direct linking to specific plugins with automatic install modal display. Users can now share URLs like ?plugin=nanobanana or ?install=grafana to show a specific plugin's installation instructions. Features: - URL query parameter detection (?plugin= or ?install=) - Auto-scroll to target plugin card - Auto-open install modal with smooth animation - 500ms delay for natural UX after scroll completion Changes: - apps/web/app/pages/index.vue: Add route query parameter handling and auto-scroll logic - apps/web/app/components/PluginCard.vue: Add autoOpenModal prop and watcher
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Apply critical fixes from PR review to enhance reliability and user experience. Changes: - Add VueUse useTimeoutFn import for proper timer management - Fix Badge color type safety with proper union types - Implement retry logic with up to 5 attempts (200ms intervals) - Add user feedback toast for persistent navigation failures - Store and cleanup timer references to prevent memory leaks - Improve network error handling with detailed logging - Separate HTTP errors from JSON parsing errors - Remove noisy error logs during normal loading Error Handling Improvements: - Silent retries during ref loading (no error spam) - Only log errors on final failure after max retries - Add onBeforeUnmount cleanup for timer references - Guard async callbacks with component lifecycle checks Type Safety: - Badge.color now properly typed as Nuxt UI color union - Prevents TypeScript compilation errors Fixes: - Memory leaks from uncleaned timers - Silent failures with no user feedback - Noisy error logs during normal page load - Race conditions during component unmount
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enable direct linking to specific plugins with automatic install modal display. Users can now share URLs with query parameters to directly open a plugin's installation instructions.
Features
?plugin=or?install=query parametersUsage Examples
Technical Changes
apps/web/app/pages/index.vue:apps/web/app/components/PluginCard.vue:autoOpenModalpropTest Plan
/?plugin=nanobanana- should scroll to nanobanana card and open install modal/?install=grafana- should scroll to grafana card and open install modal/without params - should work normally without auto-actionsScreenshots
N/A - Functional feature, behavior-based changes only