feat(nostics): add nostics diagnostics skill plugin#224
Conversation
Add the nostics plugin bundling the `nostics` and `add-diagnostic` skills from vercel-labs/nostics. Registers it in the Claude and Codex marketplaces, release-please config/manifest, and README. Note: pre-existing repo-wide multi-format drift was reverted to keep the change atomic.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (13)
📝 WalkthroughWalkthroughA new Changesnostics Plugin Registration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
🔍 Tessl Skill Review
|
| Dimension | Score | Detail |
|---|---|---|
| conciseness | ███ 3/3 | Every line earns its place. No explanation of what diagnostics are or how TypeScript works. The skill assumes Claude understands the ecosystem and focuses purely on the delta knowledge needed: naming conventions, required/optional fields, and call-site usage. |
| actionability | ███ 3/3 | Provides a concrete, executable TypeScript example with typed parameters, shows both reporting and throwing patterns, and specifies the exact naming convention (PREFIX_XNNNN with area letters). The code is copy-paste ready and the field requirements are explicit. |
| workflow clarity | ███ 3/3 | The four steps form a clear, logical sequence: locate catalog → pick code → add entry → call it. For this non-destructive operation (adding a new entry), the constraint 'Never rename or reuse a published code' serves as the key validation checkpoint, and the workflow is unambiguous. |
| progressive disclosure | ██░ 2/3 | The reference to 'the nostics skill' for full API/reporter/formatter/plugin details is a good signal for progressive disclosure, but it's not a concrete file path or link — it's a vague pointer. No bundle files are provided to verify the reference resolves. The content itself is well-organized but the navigation could be more explicit. |
Overall: This is a strong, concise skill that efficiently teaches the specific workflow for adding a diagnostic code. The naming convention, required/optional fields, and call-site patterns are all clearly specified with executable examples. The only weakness is the somewhat vague reference to 'the nostics skill' for advanced details, which could be a clearer file path or link.
Suggestions:
- Replace 'the
nosticsskill' with a concrete relative path or link (e.g., 'See nostics/SKILL.md') so the reference is unambiguous and navigable.
plugins/nostics/.agents/skills/nostics/SKILL.md
Review Details
Review Details
| Dimension | Score | Detail |
|---|---|---|
| conciseness | ██░ 2/3 | The skill is dense and information-rich, but some sections could be tightened. The reporters/conventions guidance and the production builds section include explanatory rationale that borders on verbose (e.g., explaining why reporters would duplicate output). However, most content is genuinely novel API-specific knowledge Claude wouldn't have, so it earns most of its tokens. |
| actionability | ███ 3/3 | Excellent executable code examples throughout: full defineDiagnostics setup, call-site patterns with multiple variations, custom reporter implementations, Vite config, production ternary pattern, and formatDiagnostic output. Every major feature has copy-paste-ready TypeScript. |
| workflow clarity | ██░ 2/3 | The skill covers multiple workflows (defining catalogs, calling diagnostics, production builds, Vite plugin setup) with clear patterns, but lacks explicit validation checkpoints. For example, the production build workflow doesn't include a verification step to confirm stripping worked, and there's no checklist for setting up a new catalog correctly. The migration workflow is deferred to a reference file. |
| progressive disclosure | ███ 3/3 | Clean structure with a concise but comprehensive SKILL.md overview and two well-signaled one-level-deep references (migration.md and documentation-site.md). The references are clearly described with their purpose, and the paths are accurate relative to the bundle structure. Content is appropriately split — migration details and docs-site guidance are correctly externalized. |
Overall: This is a strong, highly actionable skill that provides comprehensive API coverage with executable TypeScript examples for a complex library. Its main weakness is moderate verbosity in explanatory passages (especially around reporter behavior and stripping rationale) and the absence of explicit validation/verification steps in multi-step workflows like production build setup. The progressive disclosure is excellent, with well-organized references that match the bundle structure.
Suggestions:
- Add a brief verification step for the production build workflow (e.g., 'Verify stripping: search the production bundle for your diagnostic codes to confirm report-only calls were removed').
- Tighten the reporters section explanation — the rationale about why omitting reporters avoids duplicate output could be condensed to a single parenthetical rather than a full sentence.
To improve your score, point your agent at the Tessl optimization guide. Need help? Jump on our Discord.
Feedback
Report issues with this review at tesslio/skill-review, or send private feedback from your terminal with tessl feedback.
Up to standards ✅🟢 Issues
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
이 풀 리퀘스트는 JavaScript/TypeScript를 위한 구조화된 진단 코드 라이브러리인 nostics 플러그인을 추가합니다. 변경 사항에는 마켓플레이스 설정(.agents/plugins/marketplace.json 및 .claude-plugin/marketplace.json)에 플러그인을 등록하고, 릴리스 매니페스트 및 설정을 업데이트하며, README.md에 설명을 추가하는 작업이 포함됩니다. 또한 plugins/nostics/.agents/skills/ 경로 아래에 add-diagnostic 및 nostics 스킬 파일과 skills-lock.json 파일을 추가하였습니다. 제공된 리뷰 댓글이 없으므로 추가로 제공할 피드백은 없습니다.
|
1 participant
Summary
Adds the
nosticsplugin to the Claude Code marketplace, bundling two skills from vercel-labs/nostics.Changes
plugins/nostics/— new plugin directory with:nosticsskill (Nostics diagnostics workflow)add-diagnosticskill (inline diagnostic creation).claude-plugin/plugin.json).codex-plugin/plugin.json)plugin.json)skills-lock.jsontracking both skills.claude-plugin/marketplace.json— addednosticsentry (source of truth).agents/plugins/marketplace.json— regenerated Codex marketplacerelease-please-config.json— addedplugins/nosticspackage @1.0.0.release-please-manifest.json— addedplugins/nosticsversion entryREADME.md— added Built-in Plugins entry for nosticsNotes
Pre-existing repo-wide multi-format drift was reverted to keep this change atomic (only files for the nostics plugin are included).
Summary by cubic
Adds the
nosticsdiagnostics plugin with two skills (nostics,add-diagnostic). Registered in the Claude and Codex marketplaces and versioned viarelease-please.plugins/nostics/package with manifests (.claude-plugin/plugin.json,.codex-plugin/plugin.json,plugin.json) andskills-lock.json.nosticsskill: guidance ondefineDiagnostics, reporters, formatters, Vite plugins, and production builds.add-diagnosticskill: step-by-step flow to add new diagnostic codes..claude-plugin/marketplace.jsonand.agents/plugins/marketplace.json.release-please-config.jsonand.release-please-manifest.jsonaddplugins/nostics@1.0.0.nostics(/plugin install nostics@pleaseai).Written for commit 80c5d50. Summary will update on new commits.
Summary by CodeRabbit
/plugin install nostics@pleaseai.