Detects Microsoft WSL kernel and installs python3-dev#111
Merged
sarun87 merged 1 commit intoplatform9:masterfrom Jan 11, 2021
sirredbeard:master
Merged
Detects Microsoft WSL kernel and installs python3-dev#111sarun87 merged 1 commit intoplatform9:masterfrom sirredbeard:master
sarun87 merged 1 commit intoplatform9:masterfrom
sirredbeard:master
Conversation
Closes #107, provides python3-dev needed for building netifaces extension. Tested by hand on Ubuntu on WSL.
Contributor
|
Wonder if there is a specific field we can look at rather than a blanked grep. It does fix the issue quickly, so lgtm. |
sarun87
approved these changes
Jan 5, 2021
Contributor
Author
|
There really isn't a great way to detect if you are running inside WSL other than to check for microsoft in the WSL1 "kernel" or WSL2 kernel uname string. The next best alternative is attempting to run a Windows .exe as a test, something like See the extensive discussion here microsoft/WSL#423 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #107, provides python3-dev needed for building netifaces extension. Tested by hand on Ubuntu on WSL.