feat: logging, module toggles and env.toml user config - #349
Merged
Conversation
Wire the previously unused logger.sh into the scripts. Progress messages use log, recoverable conditions use the new warn, failures use error which writes to stderr. The logger renders escape sequences with %b, so existing multi-line messages keep working. declarations.sh sources the logger, every script gets it for free. Assisted-by: Claude Fable 5 Signed-off-by: PiX <69745008+pixincreate@users.noreply.github.com>
patch_ota now leaves disabled modules out of the patch.py call instead of passing paths that were never downloaded. patch.py skips modules without arguments, so setting ADDITIONALS[<module>]=false works end to end now. USER and REPOSITORY move to GITHUB_USER and GITHUB_REPO with env.toml overrides, so forks configure everything in env.toml and leave declarations.sh untouched. The old names collided with the login shell USER variable. ARCH accepts an override too. check_toml_env re-derives the Magisk URLs after applying overrides. Assisted-by: Claude Fable 5 Signed-off-by: PiX <69745008+pixincreate@users.noreply.github.com>
A stalled connection hung the smoke test forever. Requests now time out after 30 seconds with two retries, and a failed request reports as HTTP 000 instead of ending the run. Assisted-by: Claude Fable 5 Signed-off-by: PiX <69745008+pixincreate@users.noreply.github.com>
- Lint entry points with `shellcheck -x` so cross-file variable usage is visible, and drop the SC2034 suppression. Remove the genuinely dead `AVBROOT` array and `KEYS[PKMD]`. - Decouple the Magisk repository from GITHUB_USER. Forks kept the `pixincreate/Magisk` default wrongly derived as `<fork>/Magisk`. The repository is now `MAGISK[REPOSITORY]` with a `pixincreate/Magisk` default, override in env.toml for upstream Magisk. - Build the Magisk URL where it is used instead of at source time. This removes the re-derivation step in check_toml_env, which only existed because the URL froze GITHUB_USER before overrides applied. - Document the module toggle and Magisk overrides in env.toml. Assisted-by: Claude Fable 5 Signed-off-by: PiX <69745008+pixincreate@users.noreply.github.com>
generate_keys hardcoded the avb_pkmd.bin name in a local variable while KEYS[PKMD] sat unread, which is why it looked dead. Use the variable as the output path and note the fastboot flash command. Switch to `avbroot key encode-avb`, the current name of extract-avb. Assisted-by: Claude Fable 5 Signed-off-by: PiX <69745008+pixincreate@users.noreply.github.com>
23 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
src/logger.shinto all scripts. Progress useslog, recoverable conditions usewarn, failures useerroron stderr.patch_otaleaves disabled modules out of thepatch.pycall.ADDITIONALS[<module>]=falseworks end to end now. Before, the download was skipped but the module path was still passed, which broke the patch.USERandREPOSITORYbecomeGITHUB_USERandGITHUB_REPOwithenv.tomloverrides. Forks configure everything inenv.tomland leavedeclarations.shuntouched.ARCHaccepts an override too.Covers the "Add logging", "module toggles" and "move user specific variables out of declarations.sh" items in #12.