Use correct byte ordering function for kernel struct member (skc_num)#2002
Merged
ddelnano merged 1 commit intopixie-io:mainfrom Sep 16, 2024
Merged
Conversation
This was referenced Sep 4, 2024
ddelnano
added a commit
that referenced
this pull request
Sep 4, 2024
Summary: Update GitHub matrix to use correct 6.1.x kernel Builds after #1995 would fail since GitHub would attempt to run the 6.1.8 kernel build, which bazel no longer understands. This also updates the qemu test runner kernel that was incorrectly updated in #1999. I thought I had exercised that default value with my testing, but it didn't trigger that default value. Relevant Issues: N/A Type of change: /kind bugfix Test Plan: GitHub build on #2002 which pulls in the matrix change is no longer failing
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
ddelnano
force-pushed
the
ddelnano/fix-byte-ordering
branch
from
348d850 to
64f8171
Compare
oazizi000
approved these changes
Sep 16, 2024
ddelnano
added a commit
to ddelnano/pixie
that referenced
this pull request
Sep 23, 2024
Summary: Update GitHub matrix to use correct 6.1.x kernel Builds after pixie-io#1995 would fail since GitHub would attempt to run the 6.1.8 kernel build, which bazel no longer understands. This also updates the qemu test runner kernel that was incorrectly updated in pixie-io#1999. I thought I had exercised that default value with my testing, but it didn't trigger that default value. Relevant Issues: N/A Type of change: /kind bugfix Test Plan: GitHub build on pixie-io#2002 which pulls in the matrix change is no longer failing GitOrigin-RevId: 9ae53a8
ddelnano
added a commit
to ddelnano/pixie
that referenced
this pull request
Sep 23, 2024
…pixie-io#2002) Summary: Use correct byte ordering function for kernel struct member (skc_num) This change doesn't result in a functional difference since `ntohs` and `htons` are inverses of each other on little endian machines (and noops for big endian machines). This field's byte order caused me confusion in pixie-io#1989, so I wanted to make this struct access consistent. Relevant Issues: N/A Type of change: /kind cleanup Test Plan: Testing during pixie-io#1989 (details [here](pixie-io#1989 (comment))) Signed-off-by: Dom Del Nano <ddelnano@gmail.com> GitOrigin-RevId: 6fc0f18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Use correct byte ordering function for kernel struct member (skc_num)
This change doesn't result in a functional difference since
ntohsandhtonsare inverses of each other on little endian machines (and noops for big endian machines). This field's byte order caused me confusion in #1989, so I wanted to make this struct access consistent.Relevant Issues: N/A
Type of change: /kind cleanup
Test Plan: Testing during #1989 (details here)