Fix: Example Servers Users Parsing#527
Merged
adrianosela merged 1 commit intopion:masterfrom Jan 12, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #527 +/- ##
==========================================
+ Coverage 80.93% 81.00% +0.06%
==========================================
Files 46 46
Lines 3022 3022
==========================================
+ Hits 2446 2448 +2
+ Misses 364 363 -1
+ Partials 212 211 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
adrianosela
force-pushed
the
fix-example-servers-users-parsing
branch
from
b72480c to
2afe01d
Compare
Sean-Der
approved these changes
Jan 12, 2026
Member
|
@adrianosela amazing catch! Should we add a Would you mind squashing + adding more details to your commit message? Just copying out of GitHub Merge w/e you want! Y |
Fixes a bug in all server examples where usernames/passwords with non-alphanumeric characters are parsed incorrectly. We are using the regex (\w+)=(\w+) to parse the -users flag, but the \w+ pattern only matches [a-zA-Z0-9_]). So for example: - user-name=pass-word -> Parses as name:pass (drops user- and -word) - user:name=pass:word -> Parses as name:pass (drops before colons) - test@example.com=P@ssw0rd! -> Parses as example:P (breaks) This change drops the regex based logic in favor of strings.Split
adrianosela
force-pushed
the
fix-example-servers-users-parsing
branch
from
2afe01d to
79d308e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Example Servers Users Parsing
Fixes #364
There is a bug in all server examples where usernames/passwords with non-alphanumeric characters are parsed incorrectly. We are using the regex
(\w+)=(\w+)to parse the-usersflag, but the\w+pattern only matches[a-zA-Z0-9_]). So for example:user-name=pass-word--> Parses asname:pass(dropsuser-and-word)user:name=pass:word--> Parses asname:pass(drops everything before colons)test@example.com=P@ssw0rd!--> Parses asexample:P(completely breaks)This PR drops the regex based logic in favor of
strings.Split