Skip to content

feat(terminal): use Ctrl+V for paste - #9201

Closed
davidvornholt wants to merge 1 commit into
pingdotgg:mainfrom
davidvornholt:feat/right-control-terminal-paste
Closed

davidvornholt wants to merge 1 commit into
pingdotgg:mainfrom
davidvornholt:feat/right-control-terminal-paste

Conversation

@davidvornholt

@davidvornholt davidvornholt commented Sep 2, 2026 •

Copy link
Copy Markdown

What changed

On Linux and Windows, Ctrl+V now pastes clipboard text into T3 Code's embedded terminal. Ctrl+Shift+V and Shift+Insert still work, and Cmd+V is unchanged on macOS.

Why

Ctrl+V means paste throughout T3 Code and in most desktop apps. In the embedded terminal, however, it currently sends ^V to the shell and starts quoted input. That mismatch is easy to trip over, especially when Caps Lock is mapped to Control for familiar Caps+C and Caps+V shortcuts.

This change makes the physical Control key and a remapped Caps Lock behave consistently. It intentionally changes the terminal's quoted-insert shortcut. Users who need quoted insert will have to bind it to another key.

Testing

  • All 3,339 tests across 289 web test files pass
  • Web typecheck passes
  • Focused formatting check passes
  • Diff check passes

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Sep 2, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 2, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This changes the built-in non-macOS terminal behavior for Ctrl+V, causing the shortcut to invoke asynchronous clipboard paste instead of reaching the shell. An unresolved review comment identifies a concrete risk that ordinary left-Control Ctrl+V input is intercepted, so the behavior change needs human review.

You can add or adjust custom eligibility rules. Learn more.

@davidvornholt
davidvornholt force-pushed the feat/right-control-terminal-paste branch from 5211ced to ba6c026 Compare September 3, 2026 09:31
@davidvornholt davidvornholt changed the title feat(terminal): support right-Control paste feat(terminal): use Ctrl+V for paste Sep 3, 2026
@github-actions github-actions Bot added size:XS 0-9 changed lines (additions + deletions). and removed size:S 10-29 changed lines (additions + deletions). labels Sep 3, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit ba6c026. Configure here.

}
if (key !== "v") return false;
return isMacPlatform(platform) ? event.metaKey : event.ctrlKey && event.shiftKey;
return isMacPlatform(platform) ? event.metaKey : event.ctrlKey;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left Ctrl+V intercepted as paste

High Severity

isTerminalPasteShortcut now treats any non-macOS ctrlKey+V as paste, so Left Ctrl+V is swallowed instead of reaching the shell. The change is meant to paste only when Right Control or Shift is held, and no Right Control tracking exists to make that distinction.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit ba6c026. Configure here.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for flagging this. The behavior described here is intentional rather than a missing side check.\n\nAn earlier revision distinguished Right Ctrl so Left Ctrl+V could continue reaching the shell. After testing the actual workflow, I simplified the proposal: on Linux and Windows, ordinary Ctrl+V should paste, matching browsers and editors and making physical Ctrl+V and Caps-as-Ctrl+V behave consistently.\n\nThe tradeoff is that Ctrl+V no longer invokes terminal quoted insert. That is documented in the PR description. Ctrl+Shift+V and Shift+Insert remain supported.\n\nIf preserving shell Ctrl+V is a project requirement, this PR should not merge in its current form—or the behavior would need to become configurable. Restoring Right-Control tracking would implement a different, more specialized behavior than this PR now proposes.

Copy link
Copy Markdown
Member

Note

This comment is posted by Julius' dot

This PR intentionally replaces terminal quoted insert with clipboard paste for Ctrl+V on Linux and Windows, and the description says users must rebind quoted insert. That changes a product default, but the PR and discussion contain no explicit maintainer approval of that direction. The prior approval requirement applies. Closing this for now; agree on the shortcut behavior and scope with maintainers in an Ideas discussion, link their approval, then request reconsideration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants