Repository navigation
Conversation
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — The PR changes the production release path so npm publication reuses a Linux desktop build artifact instead of rebuilding the CLI, and it adds new cross-job artifact dependencies. It also disables declaration generation for all desktop pack targets, making the release and static-analysis configuration changes unsuitable for automatic approval. Notes:
You can add or adjust custom eligibility rules. Learn more. |
|
Note 🤖 GPT-5.6 Sol responding on behalf of Theo This is a valid human approval request. I verified the artifact handoff at The latest head,
Both paths use the same server and web build task. The Linux job archives the bundle after release branding. |
|
Taking over this one as maintainer for batch server-persistence-01. Main now contains the release artifact reuse and desktop declaration changes, and CI dependency setup has moved into a composite action. I will rebuild the remaining full-versus-filtered dependency-cache isolation from current main in an origin stack, retain your author credit, map every original change, and close this only after the replacement is published. No merge. |
|
Thanks @t3dotgg — the full-versus-filtered cache collision you identified remains useful to fix. Rebuilt that concern for current main in the one-layer stack #21885, which isolates full pnpm stores in the existing CI composite and reuses it from all four full-install release jobs. The replacement is published, linked, and unmerged; CI and hosted cache proof are being followed there. I compared the complete original diff against current main and the replacement:
134 existing focused tests pass before and after, with no test additions. Scoped workflow/action validation adds no diagnostics. Two independent Opus 5.5 / GPT-6 Sol whole-diff review rounds finished without code findings after removing one stale comment. Current-head hosted results and human release-workflow approval remain explicit gates on the replacement. Closing this superseded PR; no merge performed. Implemented with Codex gpt-6.1-sol through T3 Code. |
CI repeated expensive work across jobs. Releases rebuilt the CLI after the desktop matrix, and full installs could restore pnpm caches populated by filtered jobs but still download 749 packages.
This reuses the Linux desktop server and web bundle for npm publishing, avoids recompressing release artifacts, filters installs that need only part of the workspace, and gives full installs a separate cache namespace. Desktop bundling skips declaration output that no runtime consumer uses. Release checks still gate publishing. Publication still runs in order: npm, then GitHub Release, then hosted web.
Measured results:
The new artifact transfer adds some overhead, so the total release timing still needs a real CI run. The new full-install cache starts cold on its first run.
Verified with 86 release tests, 15 ACP tests in an isolated filtered install, 18 activity projection tests in an isolated 1,180-package server install, desktop build, pack, typecheck, and preload checks, targeted lint and format checks, and stable and nightly publish dry runs after archive restoration with native monitors. No new workflow lint issues.
Made with GPT-5.6 Sol in Codex through T3 Code.
Note
Medium Risk
Release CLI publish now depends on a Linux desktop artifact instead of a fresh build; a missing or wrong tarball fails publish rather than rebuilding locally.
Overview
CI and release workflows stop relying on
setup-vpfor install/cache on full-workspace jobs: they disable built-in cache/install, restore a dedicatedpnpm-full-v1pnpm store viaactions/cache@v6, then runvp install. Filtered jobs (server tests, release preflight/smoke, etc.) keepsetup-vpcaching but pass installargsso partial installs do not poison the full-workspace cache.Release publishing no longer runs
vp run --filter t3 buildinpublish_cli. The Linux desktop matrix job tarballsapps/server/distand uploads it; npm publish downloads and extracts that artifact instead. Desktop release uploads usecompression-level: 0to avoid recompressing large binaries.Desktop Electron pack sets
dts: falseon allpacktargets invite.config.ts, skipping declaration emit for main/preload bundles. Release docs note that the CLI npm bundle is reused from the Linux desktop build.Reviewed by Cursor Bugbot for commit 828e522. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Cut duplicate dependency and release work in CI workflows
setup-vp's automatic full-workspace installt3andmobiledependency graphs; release preflight installs onlyscriptsdistdirectory as a CLI artifact, andpublish_clidownloads it instead of rebuildingt3declarationtofalsefor the main and preload bundles in vite.config.ts so generated.d.tsfiles are omitted from desktop outputpublish_clinow depends on the Linux build artifact being present and correctly archived; a missing or staledisttarball will fail the publish jobMacroscope summarized 828e522.