Repository navigation
Conversation
When the desktop WSL backend starts with process.cwd() on /mnt/c/…, Codex app-server skills/list can hang long enough to exceed the auth probe timeout. Prefer HOME for provider probes in that case. Co-authored-by: Cursor <cursoragent@cursor.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe Codex provider status check now resolves ChangesCodex provider probe working directory
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This localized change redirects Codex status probes to the Linux home directory on WSL-mounted paths, with targeted tests covering the behavior; no actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 4 files. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Your free Security trial is over. An organization admin can activate Security or dismiss this notice. Comment |
There was a problem hiding this comment.
One finding: the new diagnostic suppression in apps/server/src/provider/Layers/codexProbeCwd.ts lacks an adjacent rationale comment.
Posted via Macroscope — Effect Service Conventions
| @@ -0,0 +1,25 @@ | |||
| // @effect-diagnostics nodeBuiltinImport:off | |||
There was a problem hiding this comment.
This new diagnostic suppression has no adjacent explanation of why the diagnostic must be disabled here (the JSDoc below documents the WSL behavior, not the suppression). Consider adding a trailing rationale, matching the repo pattern in e.g. apps/server/scripts/t3-sqlite-state.ts.
| // @effect-diagnostics nodeBuiltinImport:off | |
| // @effect-diagnostics nodeBuiltinImport:off - node:os resolves the Linux home fallback in a pure helper that runs outside any Effect runtime. |
Posted via Macroscope — Effect Service Conventions
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This is a narrowly scoped WSL-specific Codex probe fix with focused tests and limited runtime blast radius. It also adds a production-file static-analysis suppression directive, which requires human review under the repository’s review policy. You can add or adjust custom eligibility rules. Learn more. |
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
|
Thanks for the PR. We're not taking changes to the orchestration and provider layers right now: that part of the server is being rewritten for V2, and merging into the current code would either conflict with or be thrown away by that work. Closing for now. If this is still an issue once V2 lands, please reopen (or open a fresh PR against the new code) and we'll take a proper look. |
Summary
Fixes Codex provider status timeouts on T3 Code desktop when the WSL backend runs with
process.cwd()on a Windows profile mounted at/mnt/c/....Closes #8955
When probing Codex app-server status,
skills/listcan hang for many seconds on drvfs paths. T3's auth probe times out after 10s, which surfaces as "Timed out while checking Codex app-server provider status." even though Codex is installed and authenticated.This change introduces
resolveCodexProbeCwd()and uses$HOME(or Node homedir) for Codex provider probes when the server cwd is under/mnt/.Test plan
bun run test src/provider/Layers/codexProbeCwd.test.tsbun run test src/provider/Layers/ProviderRegistry.test.ts -t "uses Linux home for Codex probe cwd"Made with Cursor
Note
Use Linux home as Codex probe cwd on WSL
/mnt/drvfs mountsresolveCodexProbeCwdin codexProbeCwd.ts, which returns the server cwd as-is unless it starts with/mnt/, in which case it prefers the expandedHOMEenv var (falling back toNodeOS.homedir()whenHOMEis blank)checkCodexProviderStatusin CodexProvider.ts to pass the resolved cwd to the probe instead ofprocess.cwd()resolveCodexProbeCwdedge cases and an integration test that spies onprocess.cwdto verifyHOMEis used on/mnt/pathsHOMEis unset andNodeOS.homedir()also returns empty on a/mnt/path, the original/mnt/cwd is returned unchanged — probe behavior on drvfs stays as before in that edge caseMacroscope summarized a9cd5cc.
Summary by CodeRabbit
Bug Fixes
Tests