Skip to content

feat(provider): add Kimi CLI support - #6559

Closed
aGamingGod1234 wants to merge 11 commits into
pingdotgg:mainfrom
aGamingGod1234:agent/kimi-cli-provider
Closed

aGamingGod1234 wants to merge 11 commits into
pingdotgg:mainfrom
aGamingGod1234:agent/kimi-cli-provider

Conversation

@aGamingGod1234

@aGamingGod1234 aGamingGod1234 commented Aug 14, 2026 •

Copy link
Copy Markdown

T3 Code does not currently expose Kimi CLI as a built-in provider, so Kimi users cannot use their CLI subscription with the same session, model, permission, and remote workflows as the existing providers.

This adds Kimi as an Early Access ACP provider across server, web, desktop-backed web, and mobile. It includes session start and resume, turns and interrupts, approvals and user input, attachments, skills and slash commands, text generation, model and mode discovery, model-specific thinking levels, provider lifecycle/status handling, and a minimum Kimi CLI version gate for reliable selectable thinking support.

The implementation keeps ACP-specific complexity at the provider boundary, exposes Kimi through the existing provider contracts and UI conventions, and documents installation and compatibility requirements.

Related: #5243

Validation:

  • 128 focused tests passed; 1 capability probe skipped when unavailable
  • scoped server, web, mobile, and contracts typechecks passed
  • all 49 changed files passed formatting and changed-source lint checks

Implemented with GPT-5.6 Sol in T3 Code through the Codex harness.

Note

Add Kimi CLI provider with ACP session support, model selection, and text generation

  • Introduces a full kimi provider driver (KimiDriver.ts) that launches the Kimi CLI via ACP stdio, manages session lifecycle, and integrates with the provider registry.
  • Adds KimiAdapter.ts to handle ACP session events, permission approvals, user input, and available commands updates, with resume-first session strategy.
  • Adds KimiTextGeneration.ts for commit messages, PR content, branch names, and thread titles via ACP prompts with 180s timeout and structured JSON decoding.
  • Registers Kimi in the provider settings schema, display name map, web/mobile provider pickers (with 'Early Access'/'new' badges), and the built-in driver registry.
  • Adds skill discovery (KimiSkills.ts), home path resolution, version compatibility checking, and user question/permission parsing specific to Kimi Code CLI.
  • Risk: Kimi support is marked Early Access and depends on a minimum CLI version; sessions use session/resume before session/load, falling back only on method-not-found errors.

Macroscope summarized b06bda2.

Add Early Access Kimi CLI provider support across server, web, desktop-backed web, and mobile surfaces, including ACP sessions, model and mode discovery, permissions, attachments, skills, text generation, continuation, and lifecycle hardening. Verified with focused provider/mobile tests and typechecks.
Discover current Kimi CLI models and model-specific thinking capabilities from ACP configuration, with legacy fallback and focused coverage.
Copilot AI lite review requested due to automatic review settings August 14, 2026 00:33

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Aug 14, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 76fadfe2-737d-4455-90b9-96ab5f7db781

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XXL 1,000+ changed lines (additions + deletions). labels Aug 14, 2026
Comment thread apps/server/src/provider/acp/AcpSessionRuntime.ts
Comment thread apps/server/src/provider/Layers/KimiAdapter.ts Outdated

@macroscopeapp macroscopeapp Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the new Kimi Effect modules (KimiDriver, KimiProvider, KimiAdapter, KimiAcpSupport, KimiHome, KimiSkills, KimiVersion, KimiTextGeneration) against the service conventions. Structure, Effect.fn usage, environment-based dependency acquisition, Effect.catchTags usage, and typed error channels look right. Three small convention issues below (error detail/message derivation and one import style).

Posted via Macroscope — Effect Service Conventions

Comment thread apps/server/src/provider/Drivers/KimiDriver.ts Outdated
Comment thread apps/server/src/provider/Layers/KimiProvider.ts Outdated
Comment thread apps/server/src/provider/Layers/KimiAdapter.ts Outdated
@macroscopeapp

macroscopeapp Bot commented Aug 14, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs human review

Diff is too large for automated approval analysis. A human reviewer should evaluate this PR.

You can customize Macroscope's approvability policy. Learn more.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9ce5e2edd4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/server/src/provider/builtInDrivers.ts
Comment thread apps/server/src/provider/Drivers/KimiDriver.ts
Comment thread apps/server/src/provider/Layers/KimiAdapter.ts Outdated
Comment thread apps/server/src/provider/Drivers/KimiSkills.ts Outdated
Comment thread apps/server/src/provider/Layers/KimiAdapter.ts
Comment thread apps/server/src/provider/Layers/KimiAdapter.ts Outdated
Comment thread apps/server/src/provider/Layers/KimiProvider.ts Outdated
Comment thread apps/server/src/provider/Layers/KimiAdapter.ts Outdated
Comment thread apps/server/src/provider/Layers/KimiAdapter.ts
Comment thread apps/server/src/provider/Layers/KimiAdapter.ts Outdated

@macroscopeapp macroscopeapp Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding: the new Kimi provider status module hand-rolls a structural guard for an ACP error that already has a schema-derived predicate. Everything else (driver/adapter error attributes, service acquisition from the environment, Effect subpath namespace imports, catchTags usage) matches the repository conventions.

Posted via Macroscope — Effect Service Conventions

Comment thread apps/server/src/provider/Layers/KimiProvider.ts Outdated
Comment thread apps/server/src/provider/Layers/KimiAdapter.ts Outdated
Comment thread apps/server/src/provider/Layers/KimiAdapter.ts Outdated
Comment thread apps/server/src/provider/Layers/KimiAdapter.ts
Comment thread apps/server/src/provider/Layers/KimiAdapter.ts

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 7202523. Configure here.

Comment thread apps/server/src/provider/Layers/KimiAdapter.ts
@t3dotgg

t3dotgg commented Aug 23, 2026

Copy link
Copy Markdown
Member

Note

🤖 GPT-5.6 Sol responding on behalf of Theo

Closing this PR after an automated pass over open pull requests. Outside Kimi provider integration. Three separate implementations compete for the same unsupported provider.

@t3dotgg t3dotgg closed this Aug 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL 1,000+ changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants