Repository navigation
feat(provider): add Kimi CLI support - #6559
aGamingGod1234 wants to merge 11 commits into
Conversation
Add Early Access Kimi CLI provider support across server, web, desktop-backed web, and mobile surfaces, including ACP sessions, model and mode discovery, permissions, attachments, skills, text generation, continuation, and lifecycle hardening. Verified with focused provider/mobile tests and typechecks.
Discover current Kimi CLI models and model-specific thinking capabilities from ACP configuration, with legacy fallback and focused coverage.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Reviewed the new Kimi Effect modules (KimiDriver, KimiProvider, KimiAdapter, KimiAcpSupport, KimiHome, KimiSkills, KimiVersion, KimiTextGeneration) against the service conventions. Structure, Effect.fn usage, environment-based dependency acquisition, Effect.catchTags usage, and typed error channels look right. Three small convention issues below (error detail/message derivation and one import style).
Posted via Macroscope — Effect Service Conventions
ApprovabilityVerdict: Needs human review Diff is too large for automated approval analysis. A human reviewer should evaluate this PR. You can customize Macroscope's approvability policy. Learn more. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9ce5e2edd4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
One finding: the new Kimi provider status module hand-rolls a structural guard for an ACP error that already has a schema-derived predicate. Everything else (driver/adapter error attributes, service acquisition from the environment, Effect subpath namespace imports, catchTags usage) matches the repository conventions.
Posted via Macroscope — Effect Service Conventions
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7202523. Configure here.
|
Note 🤖 GPT-5.6 Sol responding on behalf of Theo Closing this PR after an automated pass over open pull requests. Outside Kimi provider integration. Three separate implementations compete for the same unsupported provider. |

T3 Code does not currently expose Kimi CLI as a built-in provider, so Kimi users cannot use their CLI subscription with the same session, model, permission, and remote workflows as the existing providers.
This adds Kimi as an Early Access ACP provider across server, web, desktop-backed web, and mobile. It includes session start and resume, turns and interrupts, approvals and user input, attachments, skills and slash commands, text generation, model and mode discovery, model-specific thinking levels, provider lifecycle/status handling, and a minimum Kimi CLI version gate for reliable selectable thinking support.
The implementation keeps ACP-specific complexity at the provider boundary, exposes Kimi through the existing provider contracts and UI conventions, and documents installation and compatibility requirements.
Related: #5243
Validation:
Implemented with GPT-5.6 Sol in T3 Code through the Codex harness.
Note
Add Kimi CLI provider with ACP session support, model selection, and text generation
kimiprovider driver (KimiDriver.ts) that launches the Kimi CLI via ACP stdio, manages session lifecycle, and integrates with the provider registry.resume-firstsession strategy.session/resumebeforesession/load, falling back only on method-not-found errors.Macroscope summarized b06bda2.