Repository navigation
Conversation
On macOS Electron the window controls occupy ~80px at the top-left. When the sidebar is collapsed, drag-region headers in the main content area had two problems: 1. No SidebarTrigger — once collapsed there was no way to reopen the sidebar from the thread index, settings, or ChatView empty state. 2. Fixed px-5 left padding placed text directly under the traffic lights instead of clearing them. Fix both by adding SidebarTrigger to all three Electron headers and using useSidebar() to apply pl-[82px] only when the sidebar is closed, falling back to normal padding when open. Affected headers: - _chat.index.tsx — thread index empty state - _chat.settings.tsx — settings title bar - ChatView.tsx — no-active-thread empty state + active thread bar
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Pics please |
|
Closing until you add screenshots. |
Context
The Electron app uses an offcanvas sidebar that can be fully collapsed. When collapsed, the main content area stretches to the window edge. On macOS, the traffic light buttons (close/minimise/maximise) are pinned at ~0–80px from the top-left — directly overlapping the drag-region headers in the main panel.
There were two compounding issues:
No sidebar toggle in Electron headers — the non-web headers rendered for the thread index, settings page, and ChatView empty state did not include a
SidebarTrigger. Once the sidebar was collapsed there was no way to reopen it from those pages without a keyboard shortcut.Fixed
px-5left padding — the symmetric padding placed header text and buttons directly under the traffic lights when the sidebar was closed.The regular thread view (
ChatHeader) already hadSidebarTriggerand the sidebar's own header already usedpl-[82px]correctly — the Electron-specific fallback headers were just missed.Fix
SidebarTriggerto all three Electron drag-region headersuseSidebar()to applypl-[82px]only when the sidebar is collapsed, falling back to normal padding when openFiles Changed
apps/web/src/routes/_chat.index.tsxSidebarTrigger+ conditional paddingapps/web/src/routes/_chat.settings.tsxSidebarTrigger+ conditional paddingapps/web/src/components/ChatView.tsxSidebarTriggerto empty state + conditional padding on both empty state and active thread headersTesting
In Electron on macOS: