Skip to content

fix(web): clarify file approvals and superseded attempt rows - #31624

Draft
flamboh wants to merge 2 commits into
pingdotgg:maria/redesign/2-composer-timelinefrom
flamboh:t3/redesign-changed-files-row
Draft

flamboh wants to merge 2 commits into
pingdotgg:maria/redesign/2-composer-timelinefrom
flamboh:t3/redesign-changed-files-row

Conversation

@flamboh

@flamboh flamboh commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Fix for the redesign stack, targets layer 2 (#28840).

Note

🤖 GPT-6.1 Sol on behalf of Oliver

File-change approvals render their descriptive heading as code and show absolute paths at full contrast. Expanded superseded attempts also line up with the final attempt, obscuring where the old output ends.

Use muted sans text for descriptive approval details, workspace-relative file paths in both the timeline and composer approval card, and sans diff counts. Commands keep their code font. Keep the edit and approval rows: the edit records the attempted tool action; the approval offers the waiting state and diff review. The layer already uses a true minus for these approval counts.

Mark rows belonging to expanded superseded attempts and indent them 24px under their disclosure. This is separate from tool-list indentation in #31558, and leaves that PR's header and WorkLogList lines untouched.

Validation

  • Added an assertion to the existing superseded-attempt case: failed before the change; all 133 timeline logic tests pass after it.
  • Checked the live Replay showcase at its edit approval in the web client: muted Inter detail, relative path, and +4 −0 in the timeline and approval card. Expanded superseded-attempt visual capture remains pending.
  • vp run check:changed origin/maria/redesign/2-composer-timeline --concurrency 1: all checks pass (format, lint, both knip checks, two-package typecheck, 187 tests across three files, five React Compiler cases).
  • Main also retains the unindented superseded output and monospace approval detail. This targets the redesigned timeline and composer on layer 2.
  • Web and desktop share these components. Mobile approval UI, provider adapters, wire contracts, and permissions are unchanged.

Before / after

Captures pending.

GPT-6.1 Sol through the Codex harness.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Nov 5, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant