Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for the redesign stack, targets layer 2 (#28840).
Note
🤖 GPT-6.1 Sol on behalf of Oliver
File-change approvals render their descriptive heading as code and show absolute paths at full contrast. Expanded superseded attempts also line up with the final attempt, obscuring where the old output ends.
Use muted sans text for descriptive approval details, workspace-relative file paths in both the timeline and composer approval card, and sans diff counts. Commands keep their code font. Keep the edit and approval rows: the edit records the attempted tool action; the approval offers the waiting state and diff review. The layer already uses a true minus for these approval counts.
Mark rows belonging to expanded superseded attempts and indent them 24px under their disclosure. This is separate from tool-list indentation in #31558, and leaves that PR's header and WorkLogList lines untouched.
Validation
+4 −0in the timeline and approval card. Expanded superseded-attempt visual capture remains pending.vp run check:changed origin/maria/redesign/2-composer-timeline --concurrency 1: all checks pass (format, lint, both knip checks, two-package typecheck, 187 tests across three files, five React Compiler cases).Before / after
Captures pending.
GPT-6.1 Sol through the Codex harness.