Skip to content

Add middle-click close for right panel tabs #3161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 8 commits into from
Jun 30, 2026
Merged

Add middle-click close for right panel tabs #3161

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
37519c2
Add middle-click close for right panel tabs
huxcrux Jun 19, 2026
8835218
Merge branch 'main' into t3code/feature/right-panel-middle-click-clos…
huxcrux Jun 23, 2026
a56c2e1
Merge branch 'main' into t3code/feature/right-panel-middle-click-clos…
huxcrux Jun 29, 2026
7941484
Merge branch 'main' into t3code/feature/right-panel-middle-click-clos…
huxcrux Jun 29, 2026
bc05ebb
Merge branch 'main' into t3code/feature/right-panel-middle-click-clos…
huxcrux Jun 30, 2026
2425a0d
Delete apps/web/src/components/RightPanelTabs.logic.test.ts
juliusmarminge Jun 30, 2026
4df5d7e
Delete apps/web/src/components/RightPanelTabs.logic.ts
juliusmarminge Jun 30, 2026
811baa1
Refactor tab click handling to use button check
juliusmarminge Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions apps/web/src/components/RightPanelTabs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,6 +331,19 @@ export function RightPanelTabs(props: RightPanelTabsProps) {
},
[props],
);
const handleTabMouseDown = useCallback((event: ReactMouseEvent) => {
if (event.button !== 1) return;
event.preventDefault();
}, []);
const handleTabAuxClick = useCallback(
(event: ReactMouseEvent, surface: RightPanelSurface) => {
if (event.button !== 1) return;
event.preventDefault();
event.stopPropagation();
props.onCloseSurface(surface);
},
[props],
);

useEffect(() => {
const activeTab = tabListRef.current?.querySelector<HTMLElement>("[data-active-tab='true']");
Expand Down Expand Up @@ -367,6 +380,8 @@ export function RightPanelTabs(props: RightPanelTabsProps) {
<div
key={surface.id}
data-active-tab={active}
onMouseDown={handleTabMouseDown}
onAuxClick={(event) => handleTabAuxClick(event, surface)}
onContextMenu={(event) => void handleTabContextMenu(event, surface)}
className={cn(
"group flex h-7 min-w-25 max-w-44 shrink-0 items-center gap-1.5 rounded-md px-2 text-sm",
Expand Down
Loading