Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for the redesign stack, targets layer 6 (#28845).
Note
🤖 GPT-6.1 Sol on behalf of Oliver
Focusing Search refs in the combined branch/workspace menu drops the branch chip's open highlight, and the chip cuts long branch names differently from the picker and workspace card. Keep the chip pressed for the menu's full open state and use the existing MiddleTruncate component for its branch label.
This is item 10 of the composer popup consistency task. The combined WorkspaceMenu trigger belongs to layer 6. It changes only that trigger and its label, near the footer collapse work in #31401 without changing its measurement or collapse logic. Menu open/close motion is covered by #26708.
Validation:
vp run check:changed origin/maria/redesign/6-workspace-panespassed format, lint, both knip passes, typecheck, 18 tests and React compiler checks. In an isolated Replay-only dev app, the chip retains its highlight with Search refs focused, shows both ends of a long branch name, and clears its pressed state on Escape.Before / after
Captures pending.
Built with GPT-6.1 Sol in the Codex harness through T3 Code.