Skip to content

fix(web): keep mention results visible during searches - #31529

Draft
flamboh wants to merge 1 commit into
pingdotgg:maria/redesign/2-composer-timelinefrom
flamboh:t3/redesign-fix-at-search-pump
Draft

flamboh wants to merge 1 commit into
pingdotgg:maria/redesign/2-composer-timelinefrom
flamboh:t3/redesign-fix-at-search-pump

Conversation

@flamboh

@flamboh flamboh commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Fix for the redesign stack, targets layer 2 (#28840).

Note

🤖 GPT-6.1 Sol on behalf of Oliver

Typing or backspacing in the @ menu drops file results while each search runs, briefly collapsing the menu and moving the highlight. Keep the last result list during the next search, replace it when the response settles, and preserve the highlighted item when it remains available. Mention groups keep the same order across queries.

The retained list clears when the mention, environment, workspace, thread, or question attachment changes. Shared web and desktop composer behavior is covered; native mobile and the wire contracts are unchanged. This touches the menu section of ChatComposer, away from the footer measurement changes in #31401 and spacer sizing in #30568.

Validation

  • Failing-first regressions for pending results, group order, and highlight retention; all five focused tests pass.
  • vp run check:changed origin/maria/redesign/2-composer-timeline.
  • Integrated browser verification remains pending: Boat was at capacity; local pairing navigation was rejected by automatic approval review, and the plain dev URL returned HTTP 431. The isolated server was stopped.
  • Independent reviews remain for the coordinating parent agent.

Before / after

Captures pending.

Implemented with GPT-6.1 Sol through the Codex harness.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Nov 5, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant