Repository navigation
Conversation
flamboh
added a commit
to flamboh/t3code
that referenced
this pull request
Nov 5, 2026
This was referenced Nov 5, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
🤖 Claude Opus 5.5 on behalf of Oliver
Fix for the redesign stack, targets layer 1 (#28839).
Problem
Open a pane below a chat that is scrolled to the end (Ctrl+J for a terminal, or split below). For one frame the chat is already shorter and the composer has moved up, but the timeline has not scrolled yet. The last rows show under the composer and are cut off, then the list catches up a frame later.
The timeline follows its end with LegendList's
maintainScrollAtEnd. When the list's viewport resizes, LegendList schedules its scroll to the end in the next animation frame, so the frame where the resize lands paints the old scroll position.Fix
The timeline now watches its own scroll node with
observeResize, which runs before paint. When the viewport resizes while the list is following the end (the samemaintainScrollAtEndsetting it passes to LegendList, and LegendList's own at-end threshold), it moves the scroll position to the end right away. LegendList's later scroll then finds nothing to do. ThemaintainScrollAtEndvalue moved into a variable so the prop and the resize handler read the same thing.This sits on layer 1 because the follow code and the one-frame lag are there already; layer 6 makes it easy to hit because opening a pane below shrinks the chat.
Validation
MessagesTimeline.browser.test.tsxcase: a timeline at its end shrinks from 1200 to 880 px. AResizeObserverreads the distance from the end in the resize frame. Before the fix it is 320 px on layers 1, 2 and 6. After the fix it is 0.vp run check:changed origin/maria/redesign/1-primitives-shell: format, lint, knip, typecheck, tests and React Compiler all pass. The fullMessagesTimelineandChatViewbrowser suites pass.Before / after
Captures pending.
Made with Claude Opus 5.5 in Claude Code (T3 Code).