Skip to content

fix(web): deleting the open thread no longer opens a side chat or subagent #30370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spoukyii wants to merge 2 commits into
base: main
Choose a base branch
from
+28 −3
Open

fix(web): deleting the open thread no longer opens a side chat or subagent #30370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba18c47
test(web): deleting the open thread with a side chat or subagent besi…
spoukyii Nov 3, 2026
07c7b17
fix(web): deleting the open thread no longer opens a side chat or sub…
spoukyii Nov 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion apps/web/src/components/Sidebar.logic.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -636,7 +636,28 @@ describe("getFallbackThreadIdAfterDelete", () => {
{ snoozedUntil: "2099-01-01T00:00:00.000Z", snoozedAt: "2026-03-09T10:06:00.000Z" },
],
["settled", { settledOverride: "settled", settledAt: "2026-03-09T10:06:00.000Z" }],
] as const)("skips a %s thread parked on its shelf", (_state, parked) => {
[
"side chat",
{
lineage: {
rootThreadId: ThreadId.make("thread-visible"),
parentThreadId: ThreadId.make("thread-visible"),
relationshipToParent: "fork",
sideChat: true,
},
},
],
[
"subagent",
{
lineage: {
rootThreadId: ThreadId.make("thread-visible"),
parentThreadId: ThreadId.make("thread-visible"),
relationshipToParent: "subagent",
},
},
],
] as const)("skips a %s thread the sidebar does not list", (_state, parked) => {
const fallbackThreadId = getFallbackThreadIdAfterDelete({
threads: [
makeThread({
Expand Down
8 changes: 6 additions & 2 deletions apps/web/src/components/Sidebar.logic.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1211,7 +1211,10 @@ export function resolveThreadStatusPill(input: {
}

export function getFallbackThreadIdAfterDelete<
T extends Pick<Thread, "id" | "projectId" | "createdAt" | "updatedAt" | "settledOverride"> &
T extends Pick<
Thread,
"id" | "projectId" | "createdAt" | "updatedAt" | "settledOverride" | "lineage"
> &
ThreadSortInput &
ThreadSnoozeShell,
>(input: {
Expand All @@ -1235,7 +1238,8 @@ export function getFallbackThreadIdAfterDelete<
thread.id !== deletedThreadId &&
!deletedThreadIds?.has(thread.id) &&
thread.settledOverride !== "settled" &&
!effectiveSnoozed(thread, { now }),
!effectiveSnoozed(thread, { now }) &&
!isSidebarHiddenThread(thread),
),
sortOrder,
)[0]?.id ?? null
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Resolved
Expand Down
Loading