perf(desktop): keep Linux MIME helpers off the startup path

apps/desktop/src/app/DesktopApp.test.ts

@@ -0,0 +1,233 @@
+import { assert, it } from "@effect/vitest";
+import * as NodeCrypto from "@effect/platform-node/NodeCrypto";
+import * as Deferred from "effect/Deferred";
+import * as Effect from "effect/Effect";
+import * as Layer from "effect/Layer";
+import * as FileSystem from "effect/FileSystem";
+import * as Path from "effect/Path";
+import * as HttpClient from "effect/http/HttpClient";
+import * as NetService from "@t3tools/shared/Net";
+import * as Fiber from "effect/Fiber";
+import * as Option from "effect/Option";
+import * as Ref from "effect/Ref";
+import * as Stream from "effect/Stream";
+import { vi } from "vite-plus/test";
+
+vi.mock("electron", () => ({}));
+vi.mock("@clerk/electron", () => ({ createClerkBridge: vi.fn() }));
+vi.mock("@clerk/electron/storage", () => ({ storage: vi.fn() }));
+vi.mock("../ipc/DesktopIpcHandlers.ts", () => ({
+  installDesktopIpcHandlers: () => Effect.void,
+}));
+vi.mock("../updates/DesktopRemoteUpdates.ts", () => ({ listen: Effect.void }));
+vi.mock("./DesktopStartupRecovery.ts", () => ({ listen: Effect.void }));
+
+import * as DesktopApp from "./DesktopApp.ts";
+import * as DesktopAppActivation from "./DesktopAppActivation.ts";
+import * as DesktopAppIdentity from "./DesktopAppIdentity.ts";
+import * as DesktopClerk from "./DesktopClerk.ts";
+import * as DesktopEnvironment from "./DesktopEnvironment.ts";
+import * as DesktopLegacyLocalStorage from "./DesktopLegacyLocalStorage.ts";
+import * as DesktopLifecycle from "./DesktopLifecycle.ts";
+import * as DesktopLinuxUrlHandler from "./DesktopLinuxUrlHandler.ts";
+import * as DesktopPreReadyPlatform from "./DesktopPreReadyPlatform.ts";
+import * as DesktopShutdown from "./DesktopShutdown.ts";
+import * as DesktopState from "./DesktopState.ts";
+import * as DesktopBackendPool from "../backend/DesktopBackendPool.ts";
+import * as DesktopServerExposure from "../backend/DesktopServerExposure.ts";
+import * as ElectronApp from "../electron/ElectronApp.ts";
+import * as ElectronDialog from "../electron/ElectronDialog.ts";
+import * as ElectronProtocol from "../electron/ElectronProtocol.ts";
+import * as ElectronSafeStorage from "../electron/ElectronSafeStorage.ts";
+import * as PreviewPasskeys from "../preview/Passkeys.ts";
+import * as DesktopAppSettings from "../settings/DesktopAppSettings.ts";
+import * as DesktopShellEnvironment from "../shell/DesktopShellEnvironment.ts";
+import * as DesktopSnapShot from "../snapShot/DesktopSnapShot.ts";
+import * as DesktopRendererHistory from "../telemetry/DesktopRendererHistory.ts";
+import * as DesktopUpdates from "../updates/DesktopUpdates.ts";
+import * as DesktopApplicationMenu from "../window/DesktopApplicationMenu.ts";
+import * as DesktopWindow from "../window/DesktopWindow.ts";
+import * as DesktopWslBackend from "../wsl/DesktopWslBackend.ts";
+
+import * as BrowserImport from "../preview/BrowserImport/BrowserImport.ts";
+import * as DesktopBackendConfiguration from "../backend/DesktopBackendConfiguration.ts";
+import * as DesktopCliCommand from "./DesktopCliCommand.ts";
+import * as DesktopClientSettings from "../settings/DesktopClientSettings.ts";
+import * as DesktopConnectionCatalogStore from "./DesktopConnectionCatalogStore.ts";
+import * as DesktopIpc from "../ipc/DesktopIpc.ts";
+import * as DesktopLocalEnvironmentAuth from "../backend/DesktopLocalEnvironmentAuth.ts";
+import * as DesktopManagedPolicy from "./DesktopManagedPolicy.ts";
+import * as DesktopSshEnvironment from "../ssh/DesktopSshEnvironment.ts";
+import * as DesktopSshPasswordPrompts from "../ssh/DesktopSshPasswordPrompts.ts";
+import * as DesktopTelemetryPublisher from "../telemetry/DesktopTelemetryPublisher.ts";
+import * as DesktopWebLinks from "./DesktopWebLinks.ts";
+import * as DesktopWslEnvironment from "../wsl/DesktopWslEnvironment.ts";
+import * as ElectronMenu from "../electron/ElectronMenu.ts";
+import * as ElectronShell from "../electron/ElectronShell.ts";
+import * as ElectronTheme from "../electron/ElectronTheme.ts";
+import * as ElectronWindow from "../electron/ElectronWindow.ts";
+import * as MacPermissions from "../permissions/MacPermissions.ts";
+import * as PreviewManager from "../preview/Manager.ts";
+
+it.effect(
+  "starts the backend and window while Linux registration is stalled and cancels it on shutdown",
+  () =>
+    Effect.gen(function* () {
+      const registrationStarted = yield* Deferred.make<void>();
+      const releaseRegistration = yield* Deferred.make<void>();
+      const registrationStopped = yield* Deferred.make<void>();
+      const windowStarted = yield* Deferred.make<void>();
+      const quitting = yield* Ref.make(false);
+      const events: string[] = [];
+      const record = (event: string) =>
+        Effect.sync(() => {
+          events.push(event);
+        });
+      const runApp = DesktopApp.program
+        .pipe(
+          Effect.provide(NodeCrypto.layer),
+          Effect.provideService(DesktopAppIdentity.DesktopAppIdentity, {
+            resolveUserDataPath: Effect.succeed("/isolated/userdata"),
+            configure: record("identity"),
+          } as DesktopAppIdentity.DesktopAppIdentity["Service"]),
+          Effect.provideService(ElectronApp.ElectronApp, {
+            setPath: () => Effect.void,
+            whenReady: record("ready"),
+          } as unknown as ElectronApp.ElectronApp["Service"]),
+          Effect.provideService(ElectronDialog.ElectronDialog, {
+            showErrorBox: () => Effect.die("unexpected fatal startup error"),
+          } as unknown as ElectronDialog.ElectronDialog["Service"]),
+          Effect.provideService(DesktopEnvironment.DesktopEnvironment, {
+            platform: "linux",
+            isDevelopment: false,
+            isPackaged: true,
+            configuredBackendPort: Option.some(3773),
+            defaultDesktopSettings: { serverExposureMode: "local-only" },
+          } as unknown as DesktopEnvironment.DesktopEnvironment["Service"]),
+          Effect.provideService(DesktopPreReadyPlatform.DesktopPreReadyElectronOptions, {
+            linux: null,
+            linuxPasswordStoreCommandLine: "basic",
+          }),
+          Effect.provideService(DesktopShellEnvironment.DesktopShellEnvironment, {
+            installIntoProcess: Effect.succeed(true),
+            awaitDiscovery: Effect.succeed(true),
+            updates: Stream.empty,
+          }),
+          Effect.provideService(DesktopAppSettings.DesktopAppSettings, {
+            load: Effect.void,
+            get: Effect.succeed({
+              localEnvironmentEnabled: true,
+              serverExposureMode: "local-only",
+            }),
+          } as unknown as DesktopAppSettings.DesktopAppSettings["Service"]),
+          Effect.provideService(DesktopLifecycle.DesktopLifecycle, {
+            register: Effect.void,
+            relaunch: () => Effect.void,
+          }),
+          Effect.provideService(DesktopClerk.DesktopClerk, {
+            configure: Effect.void,
+          } as DesktopClerk.DesktopClerk["Service"]),
+          Effect.provideService(ElectronSafeStorage.ElectronSafeStorage, {
+            selectedStorageBackend: Effect.succeedNone,
+          } as unknown as ElectronSafeStorage.ElectronSafeStorage["Service"]),
+          Effect.provideService(PreviewPasskeys.PreviewPasskeys, {
+            configure: Effect.void,
+          } as PreviewPasskeys.PreviewPasskeys["Service"]),
+          Effect.provideService(DesktopApplicationMenu.DesktopApplicationMenu, {
+            configure: Effect.void,
+          }),
+          Effect.provideService(DesktopUpdates.DesktopUpdates, {
+            configure: Effect.void,
+          } as unknown as DesktopUpdates.DesktopUpdates["Service"]),
+          Effect.provideService(DesktopLinuxUrlHandler.DesktopLinuxUrlHandler, {
+            register: Deferred.succeed(registrationStarted, undefined).pipe(
+              Effect.andThen(Deferred.await(releaseRegistration)),
+              Effect.ensuring(Deferred.succeed(registrationStopped, undefined)),
+            ),
+          }),
+        )
+        .pipe(
+          Effect.provideService(ElectronProtocol.ElectronProtocol, {
+            registerDesktopProtocol: () => Effect.void,
+          } as unknown as ElectronProtocol.ElectronProtocol["Service"]),
+          Effect.provideService(DesktopLegacyLocalStorage.DesktopLegacyLocalStorage, {
+            load: () => Effect.void,
+          } as unknown as DesktopLegacyLocalStorage.DesktopLegacyLocalStorage["Service"]),
+          Effect.provideService(DesktopSnapShot.DesktopSnapShot, {
+            initialize: Effect.void,
+          } as DesktopSnapShot.DesktopSnapShot["Service"]),
+          Effect.provideService(DesktopState.DesktopState, {
+            quitting,
+          } as DesktopState.DesktopState["Service"]),
+          Effect.provideService(DesktopWindow.DesktopWindow, {
+            ensureMain: record("window").pipe(
+              Effect.andThen(Deferred.succeed(windowStarted, undefined)),
+            ),
+          } as unknown as DesktopWindow.DesktopWindow["Service"]),
+          Effect.provideService(DesktopBackendPool.DesktopBackendPool, {
+            primary: Effect.succeed({
+              start: record("backend"),
+              currentConfig: Effect.succeedSome({ preflightFailure: Option.none() }),
+            }),
+            list: Effect.succeed([]),
+          } as unknown as DesktopBackendPool.DesktopBackendPool["Service"]),
+          Effect.provideService(DesktopServerExposure.DesktopServerExposure, {
+            configureFromSettings: () => Effect.succeed({ mode: "local-only" }),
+            backendConfig: Effect.succeed({ httpBaseUrl: new URL("http://127.0.0.1:3773") }),
+          } as unknown as DesktopServerExposure.DesktopServerExposure["Service"]),
+          Effect.provideService(DesktopWslBackend.DesktopWslBackend, {
+            reconcile: Effect.void,
+          } as DesktopWslBackend.DesktopWslBackend["Service"]),
+          Effect.provideService(DesktopAppActivation.DesktopAppActivation, {
+            start: Effect.void,
+          } as unknown as DesktopAppActivation.DesktopAppActivation["Service"]),
+          Effect.provideService(DesktopRendererHistory.DesktopRendererHistory, {
+            shutdown: Effect.void,
+          } as DesktopRendererHistory.DesktopRendererHistory["Service"]),
+        );
+      const app = yield* runApp.pipe(
+        Effect.provide(
+          Layer.mergeAll(
+            Layer.mock(BrowserImport.BrowserImport, {}),
+            Layer.mock(DesktopBackendConfiguration.DesktopBackendConfiguration, {}),
+            Layer.mock(DesktopCliCommand.DesktopCliCommand, {}),
+            Layer.mock(DesktopClientSettings.DesktopClientSettings, {}),
+            Layer.mock(DesktopConnectionCatalogStore.DesktopConnectionCatalogStore, {}),
+            Layer.mock(DesktopIpc.DesktopIpc, {}),
+            Layer.mock(DesktopLocalEnvironmentAuth.DesktopLocalEnvironmentAuth, {}),
+            Layer.mock(DesktopManagedPolicy.DesktopManagedPolicy, {}),
+            Layer.mock(DesktopSshEnvironment.DesktopSshEnvironment, {}),
+            Layer.mock(DesktopSshPasswordPrompts.DesktopSshPasswordPrompts, {}),
+            Layer.mock(DesktopTelemetryPublisher.DesktopTelemetryPublisher, {}),
+            Layer.mock(DesktopWebLinks.DesktopWebLinks, {}),
+            Layer.mock(DesktopWslEnvironment.DesktopWslEnvironment, {}),
+            Layer.mock(ElectronMenu.ElectronMenu, {}),
+            Layer.mock(ElectronShell.ElectronShell, {}),
+            Layer.mock(ElectronTheme.ElectronTheme, {}),
+            Layer.mock(ElectronWindow.ElectronWindow, {}),
+            Layer.mock(MacPermissions.MacPermissions, {}),
+            Layer.mock(PreviewManager.PreviewManager, {
+              isBrowserPartition: () => {
+                throw new Error("unexpected browser partition lookup");
+              },
+            }),
+            FileSystem.layerNoop({}),
+            Layer.mock(NetService.NetService, {}),
+            Path.layer,
+            Layer.succeed(
+              HttpClient.HttpClient,
+              HttpClient.make(() => Effect.die("unexpected HTTP request")),
+            ),
+          ),
+        ),
+        Effect.forkScoped,
+      );
+      yield* Deferred.await(registrationStarted);
+      yield* Deferred.await(windowStarted);
+      assert.deepEqual(events, ["identity", "ready", "identity", "backend", "window"]);
+      assert.isFalse(yield* Deferred.isDone(registrationStopped));
+      yield* (yield* DesktopShutdown.DesktopShutdown).request;
+      yield* Fiber.join(app);
+      assert.isTrue(yield* Deferred.isDone(registrationStopped));
+    }).pipe(Effect.provide(DesktopShutdown.layer)),
+);

apps/desktop/src/app/DesktopApp.ts

@@ -337,7 +337,8 @@ const startup = Effect.gen(function* () {
   yield* updates.configure;
   yield* DesktopRemoteUpdates.listen;
   yield* DesktopStartupRecovery.listen;
-  yield* linuxUrlHandler.register;
+  // Portal identity is prepared pre-ready; MIME helpers must not gate the backend or window.
+  yield* linuxUrlHandler.register.pipe(Effect.forkScoped);
   yield* bootstrap.pipe(Effect.catchCause((cause) => fatalStartupCause("bootstrap", cause)));
 }).pipe(Effect.withSpan("desktop.startup"));