Skip to content

fix(web): subagent card avatars match the delegated task row - #29185

Closed
flamboh wants to merge 2 commits into
pingdotgg:maria/redesign/1-primitives-shellfrom
flamboh:t3/redesign-fix-agent-avatar-sizes
Closed

flamboh wants to merge 2 commits into
pingdotgg:maria/redesign/1-primitives-shellfrom
flamboh:t3/redesign-fix-agent-avatar-sizes

Conversation

@flamboh

@flamboh flamboh commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Note

🤖 Claude Opus 5.5 on behalf of Oliver

Fix for the redesign stack, targets layer 1 (#28839).

A finished delegated task row and a "N subagents" card often sit right next to each other in the timeline. Both use the same avatar component, but the card shrank it to 22px with a 12px provider icon, while the row keeps the default 24px with a 14px icon. Side by side, they looked almost the same size, but not quite. The card's avatar stack also had no left padding, so the first avatar sat right on the card's rounded left edge.

Now the card uses the avatar's default size, so both are 24px with a 14px icon. The card keeps its own look: no border, card-colored ring, and per-slot backgrounds. The "+N" overflow chip grows to 24px to match. The card header gets the same 13px padding on the left that it already had on the right. That also lines the header avatars up with the subagent rows inside the card when it's expanded.

Avatar Provider icon Avatar left edge
Delegated task row 24 × 24 14 × 14 (unchanged) 20px (unchanged)
Subagents card, before 22 × 22 12 × 12 12px, on the card edge (0px gap)
Subagents card, after 24 × 24 14 × 14 25px, 13px inside the card edge
Expanded subagent rows 24 × 24 14 × 14 25px (unchanged)

Measured from bounding boxes in a Chromium render of the real timeline. The card starts at 12px and has a 12px corner radius. A single subagent renders as a plain row, not a card, so it doesn't change.

Before / after

Rendered from the real MessagesTimeline with fixture data (a finished delegated-task row above a running "2 subagents" card with one Codex and one Claude subagent), dark theme, enlarged 2×. Replay can't create subagents, so a live dev server can't produce this state.

Before (layer 1) After
Before: the subagents card's first avatar touches the card's rounded left edge, and its avatars are slightly smaller than the delegated row's After: the subagents card's avatars are the delegated row's size and sit 13px inside the card's left edge

With overflow (5 subagents), after:

After: a 5 subagents card with three avatars and a +2 chip, all inset 13px from the card's left edge

Measured: card avatar 22×22 → 24×24, icon 12×12 → 14×14, avatar-to-card-edge gap 0px → 13px; the delegated row stays 24×24 / 14×14.

Made with Claude Opus 5.5 in Claude Code.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Nov 2, 2026
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Nov 2, 2026
@macroscopeapp

macroscopeapp Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at c58170f

Macroscope's review found this PR approvable — This change aligns grouped-subagent avatars and overflow counts with the shared avatar sizing and adds matching card padding. Its effects are limited to presentation; interactions and data behavior are unchanged.

You can add or adjust custom eligibility rules. Learn more.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@macroscopeapp
macroscopeapp Bot dismissed their stale review November 2, 2026 20:17

Dismissing prior approval to re-evaluate c58170f

@maria-rcks

Copy link
Copy Markdown
Collaborator

Note

Written by gpt-6.1-sol on behalf of Maria

Verified in a real dev environment

Verified head c58170f8c85ea65fa1f7b149445e7835f250b0f7 on Linux with the real dev web app, repository Playwright, and /usr/bin/google-chrome. No mocks, fixtures, replay provider, or source changes.

  • Created a real git project and threads through the web app. Real Codex gpt-6.1-sol turns on main and the PR each completed four native subagents reading the repository. The PR showed working/completed states, three avatars, and the +1 overflow chip.
  • Checked github/main (6f41364805) first: it already uses 24px avatars and 14px icons. The mismatch belongs to the redesign base, so the matching before/after captures use that base (dada6cc0cf) and this head with the same app-created history.
  • Measured the running DOM: grouped avatars 22×22 → 24×24, provider icons 12×12 → 14×14, overflow 22×22 → 24×24, header left padding 0 → 13px. Expanded child rows remain 24×24 with 14×14 icons.
  • Click expansion/collapse, Space/Enter disclosure, opening a real child thread, and returning with "Open parent" passed. Inspected light/dark themes at 1440px and 390px widths; the narrow page had no horizontal overflow.
  • vp run check:changed dada6cc0cfba6f2a4168273fc4a5a598168bbd30 passed through blacksmith-check: format, lint, knip, affected typechecks, and React Compiler. GitHub checks have no failures or pending jobs.

Before, redesign base:

before: real four-subagent card with 22px avatars and no left header padding

After, exact PR head and matching data:

after: real four-subagent card with 24px avatars, matching overflow, and 13px left header padding

Fresh PR turn: expand/collapse, open the completed Codex child, and return to its parent:

recording of real PR subagent disclosure and child-to-parent navigation

Not verified

Native Electron, iOS/Android clients, non-Codex provider icons, and remote/relay/tunnel connections were not exercised. An initial five-child attempt on main hit Codex's native thread limit and a proxy interrupt error; fresh four-child turns succeeded on both main and the PR.

@flamboh

flamboh commented Nov 2, 2026

Copy link
Copy Markdown
Contributor Author

Dropping this one. The subagent card needs a bigger rethink than size and padding tweaks.

@flamboh flamboh closed this Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants