Skip to content

fix(web): steered turns' fold rows each show their own time and edits - #29040

Merged
maria-rcks merged 3 commits into
pingdotgg:maria/redesign/2-composer-timelinefrom
flamboh:t3/redesign-fix-steer-segment-diff
Nov 2, 2026
Merged

maria-rcks merged 3 commits into
pingdotgg:maria/redesign/2-composer-timelinefrom
flamboh:t3/redesign-fix-steer-segment-diff

Conversation

@flamboh

@flamboh flamboh commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Fix for the redesign stack, targets layer 2 (#28840).

Note

🤖 Claude Opus 5.5 on behalf of Oliver

Problem

A finished turn with a steer folds into a "Worked for …" row on top and a "Continued for …" row below each steer. The rows measured different things. The top row showed the whole turn's time and the turn's checkpoint diff. Each "Continued" row showed only its own segment's time and the edits the provider reported in it. So a segment could show a bigger diff than the whole turn, and the top row's time already included the segments below it, which read like the turn took twice as long.

Fix

In a steered turn, every fold row now describes its own segment only, measured the same way:

  • Time: the top row runs from the turn start to the first steer. Each "Continued" row keeps its own segment's time.
  • Diff: every row, the top one included, sums the provider's file edits in its own segment. Rows with no edits show no diff.

Turns without steers are unchanged: one row with the whole turn's time and the checkpoint diff, matching the changed-files card. Running turns are unchanged too.

Trade-off: steered rows use provider edit counts, so their diffs can add up to more than the changed-files card when the same lines were edited twice.

Before (layer 2) After
Before: steered Replay turn, top row "Worked for 5.2s +8 −0" covering the whole turn, "Continued for 5.3s +4 −0" below the steer After: same turn, top row "Worked for 4.5s +4 −0" covering only the work before the steer, "Continued for 5.3s +4 −0" below it

Validation

  • The steer-segment fold test in MessagesTimeline.logic.test.ts now gives each segment different edits and asserts each row's own time and diff (Worked for 10s +12 −1, Continued for 20s +40 −0). It fails on layer 2 and on the previous head of this PR, and passes now. The existing single-row checkpoint test still asserts the checkpoint diff.
  • vp run check:changed origin/maria/redesign/2-composer-timeline: all pass.
  • Captured a finished Replay turn steered mid-run, dark mode, same thread before and after.

Made with Claude Opus 5.5 in Claude Code.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Nov 2, 2026
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Nov 2, 2026
@macroscopeapp

macroscopeapp Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 599b632

Macroscope's review found this PR approvable — Steered timeline folds now show segment-specific time and edit counts, with the ending status attached to the final displayed segment. The change is confined to presentation and does not alter execution or stored data.

You can add or adjust custom eligibility rules. Learn more.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@macroscopeapp
macroscopeapp Bot dismissed their stale review November 2, 2026 04:18

Dismissing prior approval to re-evaluate e677fd2

@github-actions github-actions Bot added size:M 30-99 changed lines (additions + deletions). and removed size:XS 0-9 changed lines (additions + deletions). labels Nov 2, 2026
@flamboh flamboh changed the title fix(web): steer segments no longer show a diff bigger than the whole turn fix(web): steered turns' fold rows each show their own time and edits Nov 2, 2026
A stopped, failed or limited steered turn put its ending on the top row,
which now only spans the work before the first steer. The last segment row
that has work now carries the ending and its message.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added size:L 100-499 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Nov 2, 2026
@maria-rcks
maria-rcks merged commit a5b86d1 into pingdotgg:maria/redesign/2-composer-timeline Nov 2, 2026
33 checks passed
maria-rcks pushed a commit to flamboh/t3code that referenced this pull request Nov 3, 2026
maria-rcks pushed a commit to flamboh/t3code that referenced this pull request Nov 3, 2026
maria-rcks pushed a commit to flamboh/t3code that referenced this pull request Nov 3, 2026
maria-rcks pushed a commit that referenced this pull request Nov 3, 2026
…#29040)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
EtanHey pushed a commit to EtanHey/t3code that referenced this pull request Nov 3, 2026
maria-rcks pushed a commit that referenced this pull request Nov 3, 2026
…#29040)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
EtanHey pushed a commit to EtanHey/t3code that referenced this pull request Nov 3, 2026
flamboh added a commit to flamboh/t3code that referenced this pull request Nov 3, 2026
screen-gd pushed a commit to screen-gd/t3code that referenced this pull request Nov 4, 2026
maria-rcks pushed a commit to flamboh/t3code that referenced this pull request Nov 4, 2026
maria-rcks pushed a commit that referenced this pull request Nov 5, 2026
…#29040)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
SunkenInTime pushed a commit to SunkenInTime/t3code that referenced this pull request Nov 5, 2026
SunkenInTime pushed a commit to SunkenInTime/t3code that referenced this pull request Nov 5, 2026
SunkenInTime pushed a commit to SunkenInTime/t3code that referenced this pull request Nov 5, 2026
SunkenInTime pushed a commit to SunkenInTime/t3code that referenced this pull request Nov 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants