Skip to content

perf(shared): count terminal resume lines without allocations #28539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maria-rcks merged 1 commit into from
Nov 1, 2026
+8 −2
Merged

perf(shared): count terminal resume lines without allocations #28539

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions packages/shared/src/terminalOutput.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -598,8 +598,14 @@ export function terminalOutputResumeText(state: TerminalOutputState): string {
const { screen } = state;
const lastRow = screen.lines.length - 1;
// Moves are relative to the last line, and a viewer only holds the lines in `text`.
const shownLines = state.text.split("\n").length;
const reachable = Math.min(LIVE_LINES, shownLines) - 1;
let reachable = 0;
let cursor = 0;
while (reachable < LIVE_LINES - 1) {
const newline = state.text.indexOf("\n", cursor);
if (newline === -1) break;
reachable += 1;
cursor = newline + 1;
}
const up = (row: number) => Math.min(lastRow - row, reachable);
const goTo = (row: number, col: number) =>
(up(row) > 0 ? `${ESC}[${up(row)}A` : "") + `${ESC}[${col + 1}G`;
Expand Down
Loading