Skip to content

fix(mobile): keep iPad tab bar within narrow sidebars - #26198

Merged
juliusmarminge merged 1 commit into
mainfrom
t3/fix-ipad-tabbar-adaptive-width
Oct 28, 2026
Merged

juliusmarminge merged 1 commit into
mainfrom
t3/fix-ipad-tabbar-adaptive-width

Conversation

@juliusmarminge

Copy link
Copy Markdown
Member

Narrowing the iPad sidebar leaves the floating tab bar at its preferred width, so it extends into the chat composer. Cap the iPad bar at 280 points, the native sidebar's minimum width, and constrain it to the available width. This also tightens the spacing between the icons.

Verified on a 13-inch iPad Air simulator (iOS 26.5): reproduced the overlap by dragging the sidebar narrower, then confirmed the fix in landscape and portrait and switched between Chats, Usage, and Settings. iOS 27 was not verified. vp run check:changed passes; React Doctor reports 100/100. This is a visual layout fix, so the screenshots are the regression evidence.

Before After
Before: tab bar overlaps the composer After: tab bar stays inside the narrow sidebar

Implemented and verified with gpt-6-astra through the Codex harness in T3 Code.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Oct 27, 2026
@macroscopeapp

macroscopeapp Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 886a8c5

Macroscope's review found this PR approvable — The change constrains the iPad sidebar tab overlay to fit narrow sidebars and the available window width. Its effect is limited to layout, with non-iPad sizing and navigation behavior unchanged.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 7e884b2 and 886a8c5.

Files selected for processing: 1
  • apps/mobile/src/features/workspace/WorkspaceNativeTabs.ios.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 1 remain after this review.

Walkthrough

The iPad sidebar overlay width is now capped at 280 points and constrained by the preferred list-pane width, when set, and the window width. Other device types keep the existing width calculation.

Changes: iPad Sidebar Width

Layer / File(s) Summary
Sidebar overlay width calculation
apps/mobile/src/features/workspace/WorkspaceNativeTabs.ios.tsx
On iPad, the overlay width uses the minimum of 280 points, the preferred list-pane width or window width, and window width. Other devices retain the previous rule.

Priority: Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Possibly related PRs

Suggested reviewers: pixpmusic

Merge Risk: Minimal · up to 886a8

The sidebar width adjustment is mergeable based on the reviewed evidence.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title clearly and concisely describes the primary fix: keeping the iPad tab bar within narrow sidebars.
Description check Passed The description explains the problem, implementation, affected environment, verification steps, test results, and provides before-and-after screenshots. It does not include a dedicated Scope and appro…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the problem, implementation, affected environment, verification steps, test results, and provides before-and-after screenshots. It does not include a dedicated Scope and approval section, but the remaining required information is substantially complete for this focused bug fix.

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@juliusmarminge
juliusmarminge merged commit c570c2c into main Oct 28, 2026
29 checks passed
@juliusmarminge
juliusmarminge deleted the t3/fix-ipad-tabbar-adaptive-width branch October 28, 2026 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant