Skip to content

chore(lint): enforce schemaStructWithTag #25095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 1 commit into from
Oct 26, 2026
Merged

chore(lint): enforce schemaStructWithTag #25095

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions packages/effect-acp/src/agent.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,7 @@ const ExtRequest = jsonRpcRequest("x/test", Schema.Struct({ hello: Schema.String
const ExtResponse = jsonRpcResponse(Schema.Struct({ ok: Schema.Boolean }));
const DieResponse = Schema.Struct({
id: Schema.Number,
error: Schema.Struct({
_tag: Schema.Literal("Cause"),
data: Schema.Tuple([Schema.Struct({ _tag: Schema.Literal("Die") })]),
}),
error: Schema.TaggedStruct("Cause", { data: Schema.Tuple([Schema.TaggedStruct("Die", {})]) }),
});
const decodeRequestPermissionRequest = Schema.decodeEffect(
Schema.fromJsonString(RequestPermissionRequest),
Expand Down
5 changes: 1 addition & 4 deletions packages/effect-acp/src/client.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,7 @@ const PermissionResponse = jsonRpcResponse(AcpSchema.RequestPermissionResponse);
const ErrorResponse = Schema.Struct({ id: Schema.String, error: Schema.Unknown });
const DieResponse = Schema.Struct({
id: Schema.String,
error: Schema.Struct({
_tag: Schema.Literal("Cause"),
data: Schema.Tuple([Schema.Struct({ _tag: Schema.Literal("Die") })]),
}),
error: Schema.TaggedStruct("Cause", { data: Schema.Tuple([Schema.TaggedStruct("Die", {})]) }),
});
const decodePromptRequestLine = Schema.decodeEffect(Schema.fromJsonString(PromptRequest));
const XAiPromptCompleteNotification = jsonRpcNotification(
Expand Down
1 change: 1 addition & 0 deletions tsconfig.base.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
"namespaceImportPackages": ["@effect/platform-node", "effect"],
"effectFn": ["span", "inferred-span", "suggested-span"],
"diagnosticSeverity": {
"schemaStructWithTag": "error",
"preferTypedSchemaDecoder": "error",
"catchUnfailableEffect": "error",
"raceFirstWithSleepToTimeout": "error",
Expand Down
Loading