Skip to content

fix(shared): let SQLite reads proceed beside slow reads #24762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
juliusmarminge wants to merge 3 commits into from
Closed

fix(shared): let SQLite reads proceed beside slow reads #24762

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f2e63fd
test(shared): reproduce issue 24660 reader head-of-line blocking
juliusmarminge Oct 25, 2026
67df903
fix(shared): an open read transaction no longer stalls every other read
juliusmarminge Oct 25, 2026
37df35a
fix(shared): an interrupted read no longer leaks a reader permit
juliusmarminge Oct 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions packages/shared/src/nodeSqliteClient.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,6 +238,32 @@ it.effect("lets the writer commit while a read-only transaction is open", () =>
),
);

// regression: #24660 one read-only transaction must not hold every other read behind it
it.effect("runs an unrelated read while a read-only transaction holds a reader", () =>
withReaderClient((sql) =>
Effect.gen(function* () {
const held = yield* Deferred.make<void>();
const release = yield* Deferred.make<void>();
const holder = yield* sql
.withTransaction(
countEntries(sql).pipe(
Effect.andThen(Deferred.succeed(held, undefined)),
Effect.andThen(Deferred.await(release)),
),
)
.pipe(SqliteClient.readOnly, Effect.forkChild);
yield* Deferred.await(held);

// The holder ends only after this read, so a single reader permit deadlocks here.
const count = yield* countEntries(sql).pipe(SqliteClient.readOnly);
yield* Deferred.succeed(release, undefined);
yield* Fiber.join(holder);

assert.equal(count, 1);
}),
),
);

// regression: #19226 read-only transactions run on the separate reader connection
it.effect("rejects a write in a read-only transaction", () =>
withReaderClient((sql) =>
Expand Down
Loading
Loading