Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion apps/web/src/components/ChatView.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -480,10 +480,12 @@ export default function ChatView(props: ChatViewProps) {
const promptRef = useRef("");
const localComposerRef = useRef<ChatComposerHandle | null>(null);
const composerRef = useComposerHandleContext() ?? localComposerRef;
const threadStatus = useThreadStatus(routeThreadDetailRef);
const queuedRunEdit = useQueuedRunEdit({
environmentId,
routeThreadRef,
threadDraftTarget: baseComposerDraftTarget,
threadIsLive: threadStatus === "live",
activeThreadId: serverThread !== null || draftThread !== null ? threadId : null,
serverProjection,
promptRef,
Expand All @@ -493,7 +495,6 @@ export default function ChatView(props: ChatViewProps) {
const reportedModelSelection = serverProjection
? deriveReportedModelSelection(serverProjection)
: null;
const threadStatus = useThreadStatus(routeThreadDetailRef);
const threadSyncPhase = resolveThreadSyncPhase({
detailExists: serverProjection !== null,
shellExists: serverThread !== null,
Expand Down
25 changes: 24 additions & 1 deletion apps/web/src/components/chat/queuedMessageEdit.test.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { EnvironmentId, ThreadId } from "@t3tools/contracts";
import { EnvironmentId, MessageId, ThreadId } from "@t3tools/contracts";
import { scopeThreadRef } from "@t3tools/client-runtime/environment";
import { beforeEach, describe, expect, it } from "vite-plus/test";
import {
Expand Down Expand Up @@ -86,6 +86,29 @@ describe("queued message file edits", () => {
expect(store.getComposerDraft(editTarget)).toBeNull();
});

it.each(["", "Separate draft"])(
"handles attachment-only removals without overwriting composer %j",
(separateDraft) => {
const store = useComposerDraftStore.getState();
store.setPrompt(threadTarget, separateDraft);
store.setPrompt(editTarget, "Original message");
store.setQueuedMessageEdit(editTarget, {
messageId: MessageId.make("message:queued"),
originalText: "Original message",
removedAttachmentIds: ["attachment:removed"],
});
expect(
recoverQueuedMessageEdit({ editTarget, threadTarget, originalText: "Original message" }),
).toBe(separateDraft ? "discarded" : "kept");
expect(store.getComposerDraft(threadTarget)?.prompt).toBe(
separateDraft || "Original message",
);
expect(store.getComposerDraft(threadTarget)?.files).toEqual([]);
expect(store.getComposerDraft(threadTarget)?.queuedMessageEdit).toBeUndefined();
expect(store.getComposerDraft(editTarget)).toBeNull();
},
);

it("does not overwrite a separate draft when the queued run leaves", () => {
const store = useComposerDraftStore.getState();
store.setPrompt(threadTarget, "Separate draft");
Expand Down
7 changes: 6 additions & 1 deletion apps/web/src/components/chat/queuedMessageEdit.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,14 @@ export function recoverQueuedMessageEdit(input: {
const draft = store.getComposerDraft(input.editTarget);
const dirty =
draft !== null &&
(draft.prompt !== input.originalText || draft.images.length > 0 || draft.files.length > 0);
(draft.prompt !== input.originalText ||
draft.images.length > 0 ||
draft.files.length > 0 ||
(draft.queuedMessageEdit?.removedAttachmentIds.length ?? 0) > 0);
if (dirty && !composerDraftHasUserContent(store.getComposerDraft(input.threadTarget))) {
store.moveComposerPromptAndImages(input.editTarget, input.threadTarget);
// A new composer draft keeps the edited content, not IDs belonging to the old queued message.
store.setQueuedMessageEdit(input.editTarget, undefined);
return "kept";
}
store.clearComposerContent(input.editTarget);
Expand Down
Loading
Loading