Repository navigation
fix(bitbucket): honor repository in pull request URLs - #23442
yashranaway wants to merge 1 commit into
Conversation
|
Warning Review limit reachedOnly developers with an assigned seat can use this organization's usage-based review budget, and seats here are assigned manually. Ask an admin to assign a seat, or change the review continuation mode in Billing. Next included review available in 39 minutes. View limit details
Comment |
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a narrowly scoped Bitbucket bug fix that honors the repository encoded in pull-request URLs and prevents mismatched checkout remotes from being reused. Regression tests cover URL lookup, fork checkout, context handling, and the existing number-only path. You can add or adjust custom eligibility rules. Learn more. |
|
Closing in favour of #25052, which makes the same change. Thanks for the work here! |
Opening a Bitbucket PR URL from another repository uses the checkout's repository instead, which can select the wrong PR with the same number. Honor the repository in the URL and only reuse a checkout remote when it matches the PR source.
Regressions fail before the fix for lookup and checkout, with and without an explicit remote context. All 24 API tests pass, including number-only and fork checkout behavior. Targeted lint, package typecheck, and server typecheck pass. API responses and Git operations were tested through fixtures.