Skip to content

test(web): timeline restore test no longer flakes on a late live-follow save #22528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tris203 wants to merge 1 commit into from
Closed

test(web): timeline restore test no longer flakes on a late live-follow save #22528

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions apps/web/src/components/chat/MessagesTimeline.browser.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1504,15 +1504,17 @@ describe("MessagesTimeline scroll position", () => {

it("restores a manual reading position after reopening and switching threads", async () => {
const props = baseProps();
function Chat() {
function Chat({ routeThreadKey = props.routeThreadKey }: { routeThreadKey?: string }) {
const [liveFollowEnabled, setLiveFollowEnabled] = useState(true);
// The chat view stops following the live edge when the reader scrolls.
return (
<div className="contents" onWheelCapture={() => setLiveFollowEnabled(false)}>
<MessagesTimeline
{...props}
routeThreadKey={routeThreadKey}
timelineEntries={tallEntries}
liveFollowEnabled={liveFollowEnabled}
onManualNavigation={() => setLiveFollowEnabled(false)}
/>
</div>
);
Expand All @@ -1532,9 +1534,7 @@ describe("MessagesTimeline scroll position", () => {
scrollOffset: offset,
});

const timeline = (routeThreadKey: string) => (
<MessagesTimeline {...props} routeThreadKey={routeThreadKey} timelineEntries={tallEntries} />
);
const timeline = (routeThreadKey: string) => <Chat routeThreadKey={routeThreadKey} />;
await using screen = await renderElement(timeline(props.routeThreadKey));
const reopenedViewport = await waitForList(props);
await vi.waitFor(() =>
Expand Down
Loading