Skip to content

fix(web): a refused review shows GitHub's reason #22382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tiliakoos wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −1
Open

fix(web): a refused review shows GitHub's reason #22382

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion apps/web/src/components/pullRequest/PullRequestReviewForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,13 @@ import { CheckIcon, MessageSquareIcon, XCircleIcon } from "lucide-react";
import { useState, type ReactNode, type RefObject } from "react";

import { pullRequestEnvironment } from "~/state/pullRequests";
import { squashAtomCommandFailure } from "@t3tools/client-runtime/state/runtime";

import { Button } from "../ui/button";
import { Select, SelectItem, SelectPopup, SelectTrigger } from "../ui/select";
import { Textarea } from "../ui/textarea";
import { toastManager } from "../ui/toast";
import { readableFailure } from "./pullRequestDetail.logic";
import {
pullRequestReviewKey,
usePendingReviewComments,
Expand Down Expand Up @@ -94,7 +96,14 @@ export function PullRequestReviewForm({
});
onPendingChange(false);
if (result._tag === "Failure") {
toastManager.add({ type: "error", title: "The review could not be submitted" });
toastManager.add({
type: "error",
title: "The review could not be submitted",
description: readableFailure(
squashAtomCommandFailure(result),
"The host refused the review. Your draft is still here to try again.",
),
});
return;
}
// More remarks may have been added while the host was accepting this snapshot. Leave those,
Expand Down
Loading