[UtkarshUsername]

Problem

The cross-architecture Windows payload test treats any command with ELECTRON_RUN_AS_NODE=1 as the primary native-load probe. When the test runner inherits this variable, unrelated validation commands inherit it too, causing a false failure.

Change

Identify the primary probe by the packaged application executable path. Keep checking that the host Node validation command runs with an empty NODE_PATH. This changes only the test assertion.

Scope and approval

This is a small, focused fix for an obvious environment-sensitive test defect, qualifying for the exception without a prior issue or discussion. It starts from upstream main independently of #21766.

Verification

On Windows x64 with inherited ELECTRON_RUN_AS_NODE=1:

• Before: the cross-architecture probe test failed with expected false, received true.
• After: vp test run lib/cli-external-packages.test.ts build-desktop-artifact.test.ts -t '^(?!.*builds and stages native capture helpers for each Linux architecture).*$' passed 97 tests, skipping only the existing Windows POSIX-permission failure addressed separately in test(scripts): skip POSIX helper permission checks on Windows #21766. Runtime: 9.85s.
• vp lint scripts/build-desktop-artifact.test.ts passed.
• vp run --filter @t3tools/scripts typecheck passed.
• git diff --check passed.

Model: gpt-6.1-sol. Harness: Codex in T3 Code.

[macroscopeapp]

Approvability

Verdict: Approved at 323756b

Macroscope's review found this PR approvable — The sole changed file is an ignored test script, so the change is confined to test-harness behavior and does not alter product runtime behavior or defaults. It also introduces no static-analysis suppression or sensitive-area changes.

Notes:

• No code objects were reviewed. Approvability was decided on eligibility alone.

No code changes detected at 535d415. Prior analysis still applies.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: 6575ce3
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: 76abb99c-4c9f-4b38-a14f-ce18b46dd363

Commits

Reviewing files that changed from the base of the PR and between 1c43770 and 535d415.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

Walkthrough

The cross-architecture Windows payload test now asserts that validation does not spawn the packaged application executable.

Changes: Windows Payload Validation

Layer / File(s)	Summary
Executable spawn assertion scripts/build-desktop-artifact.test.ts	The test now checks that validation does not spawn the packaged Windows executable, replacing the check for ELECTRON_RUN_AS_NODE=1.

Priority: Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Suggested reviewers: juliusmarminge

Merge Risk: Minimal · previous review 1c437

The test change is mergeable with no identified correctness or availability risk.

Architecture risk: Low · up to 32375

The change affects 1 system.

Changed systems: scripts

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

• observed — scripts (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

• observed — Modified behavior in scripts/build-desktop-artifact.test.ts: The test now asserts that the packaged Windows executable was not spawned, replacing the check that no spawned command had ELECTRON_RUN_AS_NODE set to "1".

Pre-merge checks: 4

Check name	Status	Explanation
Description check		The description includes all required sections. It clearly explains the environment-sensitive test defect, the executable-path assertion change, scope justification, focused Windows verification, and …
Title check		The title is concise, specific, and accurately describes the main test assertion change: identifying the Windows native probe by its executable.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description includes all required sections. It clearly explains the environment-sensitive test defect, the executable-path assertion change, scope justification, focused Windows verification, and additional lint, typecheck, and diff checks.

Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}