Skip to content

fix(pi): support persisted sessions in RPC launch #21511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 3 commits into from
Oct 19, 2026
Merged

fix(pi): support persisted sessions in RPC launch #21511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7bf4f21
fix(pi): accept persisted sessions in RPC launch
juliusmarminge Oct 19, 2026
e02ed9b
fix(pi): keep ephemeral launches independent of persisted sessions
juliusmarminge Oct 19, 2026
c0599cf
Merge remote-tracking branch 'origin/main' into HEAD
juliusmarminge Oct 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/provider-pi/src/server/mcpInjection.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ describe("pi T3 MCP injection", () => {
environment: {},
mcpSession,
extensionPath: "/tmp/cache/pi-t3-mcp-extension.ts",
sessionPath: "/fake/persisted.jsonl",
ephemeral: true,
disableExtensions: true,
disableTools: true,
Expand Down
7 changes: 6 additions & 1 deletion packages/provider-pi/src/server/mcpInjection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,7 @@ export function buildPiRpcLaunch(input: {
readonly environment: NodeJS.ProcessEnv;
readonly mcpSession: McpProviderSessionConfig | undefined;
readonly extensionPath: string | undefined;
readonly sessionPath?: string | undefined;
readonly ephemeral?: boolean;
readonly disableExtensions?: boolean;
readonly disableTools?: boolean;
Expand All @@ -265,7 +266,11 @@ export function buildPiRpcLaunch(input: {
const args = [
"--mode",
"rpc",
...(input.ephemeral === true ? ["--no-session"] : []),
...(input.ephemeral === true
? ["--no-session"]
: input.sessionPath !== undefined
? ["--session", input.sessionPath]
: []),
...launchArgs,
// Restrictions follow user launch args so a configured --tools or
// --extension cannot silently re-enable unattended text-generation code.
Expand Down
Loading