Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a focused Android navigation bug fix that redirects existing workspace resets to the root navigator when nested Settings or New task stacks are focused. The implementation is small, localized, and covered by a targeted regression test. You can add or adjust custom eligibility rules. Learn more. |
Contributor
Member
Author
|
Note 🤖 Claude Opus 5.5 responding on behalf of Theo Closing: this change shipped in #21071, which combined it with the other Android foldable fixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Android foldables, the sidebar stays visible while Settings or New task is open, but tapping a thread there did nothing. The same was true for PRs in the sidebar and the navigation rail. The sidebar felt broken.
The sidebar renders in the root stack's layout, so its
useNavigation()is the navigation container. A containerdispatch(state => ...)runs on the deepest focused navigator. With Settings or New task open, that is their nested stack. The workspace reset was built from the nested state, and both stacks rejected it.The new
resetAndroidWorkspacereads the root stack state and sends the RESET withtargetset to the root key. This is the same approach React Navigation uses forresetRoot. All workspace reset call sites now use it. A focused test covers the nested-Settings case and fails without the fix.Not verified on a device: T3 device support was unavailable during this work.
Reviewed with sol-loop: 1 round with GPT-6.1 Sol. Sol verdict: approved.
Created with Claude Opus 5.5 in Claude Code.
🤖 Generated with Claude Code